Skip to content

Antalya 26.3 Backport of #101577 - Fix crash when reading Iceberg table through materialized view#1772

Merged
zvonand merged 1 commit into
antalya-26.3from
backports/antalya-26.3/101577
May 12, 2026
Merged

Antalya 26.3 Backport of #101577 - Fix crash when reading Iceberg table through materialized view#1772
zvonand merged 1 commit into
antalya-26.3from
backports/antalya-26.3/101577

Conversation

@mkmkme
Copy link
Copy Markdown
Collaborator

@mkmkme mkmkme commented May 9, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix server crash (LOGICAL_ERROR) when SELECT-ing from a materialized view backed by an IcebergLocal table engine (ClickHouse#101577 by @groeneai).

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

…sh-93278

Fix crash when reading Iceberg table through materialized view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Workflow [PR], commit [c2f48c0]

@alsugiliazova
Copy link
Copy Markdown
Member

Verification: PR #1772

PR-added test — GREEN

04077_iceberg_mv_select_crash6/6 OK across every stateless job that picked it up:

Job Status
Stateless tests (amd_asan, distributed plan, parallel, 4/4) OK
Stateless tests (amd_debug, distributed plan, s3 storage, parallel) OK
Stateless tests (amd_debug, parallel) OK
Stateless tests (arm_asan, azure, parallel, 4/4) OK
Stateless tests (arm_asan, targeted) OK
Stateless tests (arm_binary, parallel) OK
Fast test SKIPPED (expected, Tags: no-fasttest)

The MV-over-Iceberg crash path has clean positive coverage.

CI overview (head commit)

  • PR test workflow: 42 success / 51 skipped / 3 failure
  • Regression workflow: 30 success / 66 skipped / 4 failure (chronic baseline)
  • One pending action_required job (queue/auth)

PR test-workflow failures

Check Verdict
Integration tests (amd_asan, db disk, old analyzer, 3/6) — 24 × test_s3_cluster/test.py::* Cascade failure (all 24 fail at the same timestamp). Same pattern recurs across antalya-26.3 PRs 1773, 1767, 1757, 1741, 1731, 1692 in last 30 days. PR diff is in StorageMaterializedView, not s3Cluster — not PR-caused.
Stateless tests (amd_debug, sequential)00157_cache_dictionary Pre-existing flake (78 fails / 25 PRs in 30d). Unrelated.
Stateless tests (arm_asan, azure, sequential, 2/2)03443_shared_storage_snapshots Pre-existing flake (29 fails / 17 PRs in 30d). Unrelated.

Regression-workflow failures (chronic baseline on antalya-26.3)

Suite Fails
Swarms (Aarch64 + Release) 226
Parquet (Aarch64 + Release) 34
S3Export partition (Aarch64 + Release) 20
S3Export part (Aarch64 + Release) 14

Same fingerprint as sibling antalya-26.3 PRs (1771, 1770, 1769, 1767, 1759, …). No new failure modes.

Caveat — partial frontport

This PR lands on antalya-26.3 while companion features from antalya-26.1 are still being frontported in parallel. Final re-verify recommended once the rest of the bundle lands.

Verdict

Safe to merge.

  • PR’s new test 04077_iceberg_mv_select_crash passes 100% (6/6 stateless runs).
  • Test-level failures are all well-known pre-existing flakes (00157_cache_dictionary, 03443_shared_storage_snapshots) or the recurring test_s3_cluster cascade.
  • Regression failures match the chronic antalya-26.3 baseline.

@alsugiliazova
Copy link
Copy Markdown
Member

Audit: PR #1772 — Antalya 26.3 Backport of #101577 — Fix crash when reading Iceberg table through materialized view

AI audit note: This review comment was generated by AI (Cursor agent, audit-review skill).

Confirmed defects

No confirmed defects in reviewed scope.

@alsugiliazova alsugiliazova added the verified Approved for release label May 11, 2026
@zvonand zvonand merged commit 7880a1e into antalya-26.3 May 12, 2026
289 of 313 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants