fix: upgrade packages to fix new CVEs#313
Merged
iFurySt merged 7 commits intoAmoyLab:mainfrom Apr 22, 2026
Merged
Conversation
fix: bump vulnerable go modules in unla
Contributor
Reviewer's GuideThis PR updates the Go toolchain version and refreshes a set of direct and indirect Go module dependencies (notably OpenTelemetry, golang.org/x packages, gRPC, QUIC, and various encoding and DB-related libraries) to address new CVEs while cleaning up some now-unneeded indirect requirements and normalizing some indirect deps as direct ones. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The OpenTelemetry dependencies are mostly aligned at v1.43.0, but
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpcis pinned at v1.40.0, which may cause subtle incompatibilities; consider aligning it with the rest of the OTel stack. - You removed
gorm.io/driver/sqlite(and the directgithub.com/mattn/go-sqlite3dependency) while still depending on sqlite viagithub.com/glebarez/go-sqlite; double‑check that all call sites expecting the gorm sqlite driver are updated or that the old driver is intentionally no longer needed. - Several
golang.org/x/*andgoogle.golang.org/genprotomodules are pinned to pseudo‑versions with future timestamps (e.g., 2025/2026), which can make builds less reproducible and may not correspond to real upstream tags; consider revisiting these versions to ensure they are intentional and resolvable via your module proxy.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The OpenTelemetry dependencies are mostly aligned at v1.43.0, but `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` is pinned at v1.40.0, which may cause subtle incompatibilities; consider aligning it with the rest of the OTel stack.
- You removed `gorm.io/driver/sqlite` (and the direct `github.com/mattn/go-sqlite3` dependency) while still depending on sqlite via `github.com/glebarez/go-sqlite`; double‑check that all call sites expecting the gorm sqlite driver are updated or that the old driver is intentionally no longer needed.
- Several `golang.org/x/*` and `google.golang.org/genproto` modules are pinned to pseudo‑versions with future timestamps (e.g., 2025/2026), which can make builds less reproducible and may not correspond to real upstream tags; consider revisiting these versions to ensure they are intentional and resolvable via your module proxy.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update Go toolchain and core dependencies to newer versions, primarily to address security vulnerabilities in transitive libraries.
Enhancements: