Skip to content

fix: revert redis notifier watch change #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iFurySt merged 1 commit into from
Apr 22, 2026
+3 −11
Merged

fix: revert redis notifier watch change #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions internal/mcp/storage/notifier/redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,12 @@ func (r *RedisNotifier) Watch(ctx context.Context) (<-chan *config.MCPConfig, er

ch := make(chan *config.MCPConfig, 10)

// Capture the current tail before starting the watch loop so callers do not
// miss updates published immediately after Watch returns.
lastID := "0-0"
latest, err := r.client.XRevRangeN(ctx, r.streamName, "+", "-", 1).Result()
if err != nil && !errors.Is(err, redis.Nil) {
return nil, fmt.Errorf("failed to get stream tail: %w", err)
}
if len(latest) > 0 {
lastID = latest[0].ID
}

go func() {
defer close(ch)

// Start from the latest message ($ means read only new messages)
lastID := "$"

for {
select {
case <-ctx.Done():
Expand Down
Loading