fix(feed): anchor filter button to the right side, match Trending pattern#14334
Merged
Conversation
…tern Move the feed tabs and chronological filter from the inline `rightDecorator` slot into the Header `bottomBar` slot with `justifyContent='space-between'`, so the filter button is anchored to the right edge of the header — same UI pattern Trending uses. Apply the equivalent change to the mobile-web header. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14334.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The feed filter button (the dropdown next to the Chronological tab) was sitting inline next to the feed tabs in the Header's
rightDecoratorslot, instead of being anchored to the right edge of the header like Trending does.Move both the
FeedTabsandFeedFiltersfromrightDecoratorinto the HeaderbottomBarslot, wrapped in<Flex w='100%' justifyContent='space-between'>— this is the exact pattern TrendingPageContent uses (tabs on the left, filter buttons on the right). The mobile-web header gets the equivalent change:justifyContentflips fromcentertospace-betweenwithw='100%', so the filter is pushed to the right edge.When the For You tab is active there is no filter button — only the tabs render — which matches existing behavior.
This supersedes #14315, which introduced the filter button but kept it clumped next to the tabs.
Files changed
rightDecorator→bottomBarwithspace-betweenjustifyContent='center'→space-betweenwithw='100%'Test plan
All Posts/Original Posts/Repostsoptions work and filter the lineup🤖 Generated with Claude Code