feat(mobile): chronological feed filter button uses drawer pattern#14335
Merged
Conversation
Replace the inline SelectablePill filter row with a single icon filter button in the right side of the feed header, opening a bottom-sheet drawer with radio options for All Posts / Original Posts / Reposts. Mirrors the Trending screen's filter button pattern (TrendingFilterButton + TrendingCombinedFilterDrawer). - Add 'FeedFilter' modal to the common Modals union and initial state - New FeedFilterButton (icon SelectablePill in MobileRootHeader children) - New FeedFilterDrawer (RadioButton list inside AppDrawer) - Register FeedFilter drawer in Drawers.tsx commonDrawersMap - Remove the old inline FeedFilters pill row from FeedScreen Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14335.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to apps#14332. The merged version of that PR rendered the filter as a single inline
FilterButtonpill, but the desired UX is the Trending screen pattern: a single icon button anchored to the right of the screen header that opens a bottom-sheet drawer.This PR replaces the inline pill with that pattern:
FeedFilterButton— an iconSelectablePillrendered in theMobileRootHeaderright-side children slot, mirroringTrendingFilterButton.FeedFilterDrawer— a bottom sheet with radio options for All Posts / Original Posts / Reposts, mirroringTrendingCombinedFilterDrawer.FeedFilters.tsxcomponent and its rendering in the Chronological tab body.FeedFilterto the commonModalsunion and initial state; registers the drawer inDrawers.tsx.Test plan
🤖 Generated with Claude Code