fix(mobile): comment kebab menu doesn't open reliably#14344
Closed
dylanjeffers wants to merge 3 commits into
Closed
fix(mobile): comment kebab menu doesn't open reliably#14344dylanjeffers wants to merge 3 commits into
dylanjeffers wants to merge 3 commits into
Conversation
Instruments three key contest interactions following the existing
'Remix Contest:' event prefix and {remixContestId, trackId} property
shape used by the host/pick-winners events:
- REMIX_CONTEST_VIEW: contest page/screen first resolves trackId+eventId
- REMIX_CONTEST_ENTER: user taps Enter Contest / Upload Remix
- REMIX_CONTEST_VIEW_SUBMISSIONS: user opens the submissions tab
Mobile submissions-tab firing uses useFocusedTab from
react-native-collapsible-tab-view because the contest tabs mount
eagerly (lazy: false) — a plain mount effect would fire even for
users who only view the Details tab.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…t sections Bug 1 (web): Align static explore section visibility with SearchResults render condition — hide sections when inputValue is set (during debounce window) in addition to when showSearchResults is true, so Premium and other filters applied via the filter pills always suppress unfiltered curated sections. Bug 2 (web): Guard empty-state tile behind !isPending in AlbumResultsPage and PlaylistResultsPage so the NoResultsTile is not shown while the query is still in its initial loading phase, preventing a spurious empty-state flash when combining "Downloads Available" + "Electronic" genre filters. Bug 3 (mobile): Include category !== 'all' in the showSearch guard on the explore screen so tapping a content-type pill (Tracks, Albums, etc.) immediately shows the filtered SearchResults without requiring a second filter to be added. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The handler toggled isOpen/isVisible from captured state, which let the two booleans drift out of sync when the drawer was swipe-closed mid-animation — from then on, taps re-rendered the drawer with isOpen=false and it never slid back in. Always set both true on press and let onClose/onClosed drive the close path. Also remove a redundant CommentSectionProvider wrap inside the Portal: the rows close over the outer section context, and the provider short-circuits to null until its useTrack query rehydrates, which can swallow the drawer entirely. CommentDrawerHeader already portals its action drawer without this wrapper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 097e2f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Closing as a duplicate of #14342, which has the same focused fix to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tapping the kebab (three-dot) menu on a comment in mobile was unreliable — sometimes nothing happened, and Edit/Delete were inaccessible. Two issues compounded:
handlePresstoggledisOpen/isVisiblefrom captured state. If the user swipe-closed the drawer and re-tapped the kebab while the slide-out animation was still in flight, the two booleans drifted out of sync. From then on, taps re-rendered the action drawer withisOpen=falseso it never slid in. NowhandlePressalways sets both totrue; closing is driven by the drawer's ownonClose/onClosedcallbacks.<CommentSectionProvider entityId={entityId}>wrapped the action drawer inside the Portal.CommentSectionProvidershort-circuits tonullwhile itsuseTrackquery rehydrates, which can swallow the drawer entirely. The rows close over the outer comment-section context, so the wrapper was dead weight — CommentDrawerHeader already portals its action drawer without it.Fixes the same Edit / Delete / Pin / Mute / Flag entries that already work in the web overflow menu.
Test plan
🤖 Generated with Claude Code