ci(consistency): declare contents: read on the Consistency workflow#3490
Open
arpitjain099 wants to merge 1 commit into
Open
ci(consistency): declare contents: read on the Consistency workflow#3490arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The Consistency workflow runs lint / format / changelog-verify checks on pull_request and push to main and doesn't touch the API. Mirror the top-level permissions style already used in prepare-auto-release-branch.yml and pin the default GITHUB_TOKEN to read-only. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
microsoft-github-policy-service
Bot
added
customer-reported
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
33a5d79 to
e56bd79
Compare
Author
|
Hi @msyyc, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
There was a problem hiding this comment.
Pull request overview
Adds a top-level permissions: contents: read block to the Consistency workflow to follow least-privilege best practice for the default GITHUB_TOKEN.
Changes:
- Declares read-only
contentspermission at the workflow level inconsistency.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENto read-only forconsistency.yml, the lint / format / changelog-verify workflow that runs on PRs, pushes tomain, and the merge group.The sibling
prepare-auto-release-branch.ymlalready declares a top-levelpermissions:block (grantingcontents: writethere), so this PR follows the same style for the read-only workflow.Verified by parsing the YAML with
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/consistency.yml'))". No behavior change.