fix(infra): AILZ deployment fixes - private endpoints, DNS, authentication , and ingress#46
Open
sihbher wants to merge 31 commits intoAzure:mainfrom
Open
fix(infra): AILZ deployment fixes - private endpoints, DNS, authentication , and ingress#46sihbher wants to merge 31 commits intoAzure:mainfrom
sihbher wants to merge 31 commits intoAzure:mainfrom
Conversation
Prevents compilation error in basic mode where networkConfig.privateDnsZoneIds does not exist
- Remove ACR reuse references (always creates new ACR per workload) - Add Queue Storage DNS Zone to all relevant sections - Add troubleshooting section for missing Queue Storage DNS Zone - Add important note about Queue DNS Zone requirement in AILZ mode - Update manual configuration steps with Queue DNS Zone ID - Fix inconsistent ACR descriptions in deployment sections - Ensure all documentation aligns with changes.md Items 4 and 8
# Conflicts: # .DS_Store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChangeDetails.md
12 fixes resolving end-to-end
azd upfailures inailz-integratedmode. All changes are backward-compatible withbasicmode.Provisioning Fixes (
azd provision)privateEndpointsSubnetId→privateEndpointSubnetIdsin property nameUnmatchedPrincipalTypefordeployer().objectIdprincipalTypehardcoded as'User'; fails with managed identityprivateDnsZoneGroups; added explicit modulespostprovisionhookSTORAGE_ACCOUNT_NAMEoutput returns module namestorageAccount.namereturns deployment name; fixed tostorageAccount.outputs.nameDeploy Fixes (
azd deploy)remoteBuild: trueincompatible with private ACRpublicNetworkAccess: Disabled; removedremoteBuildprovisionanddeploy; addedpredeployhook with 3-phase readiness gateexternalIngress: falsein internal CAE blocks all non-CAE VNet traffic; set totrueexistingQueuePrivateDnsZoneIdnever reached Bicep (missingparameters.jsonmapping + storage module param); closes the parameter flow chain started in item 8Files Changed
azure.yaml— removedremoteBuild, addedpredeployhookinfra/bicep/main.bicep— 10+ fixes across validation, storage, DNS zone groups, Container Apps ingressinfra/bicep/main.parameters.json— addedexistingQueuePrivateDnsZoneIdmappinginfra/bicep/modules/storage.bicep— fixedoutput nameto useoutputs.nameinfra/bicep/modules/storage.bicep,app-config-store.bicep— dynamicprincipalTypedetectioninfra/bicep/modules/private-endpoint-dns-zone-group.bicep— new: reusable DNS zone group moduleinfra/scripts/pre-provision.sh— added Docker daemon reachability checkinfra/scripts/pre-deploy.sh— rewrote with ACR pull readiness gate (RBAC polling + DNS check + stabilization wait)infra/scripts/post-provision.sh— added App Config key creation in AILZ modeinfra/README.md— updated deployment instructions for both modesDeployment Impact
Before
azd upinailz-integratedmode failed at multiple stages:UnmatchedPrincipalType, silent AVM DNS zone group failures, 403 on App Config keys, wrong storage output name, missing queue DNS zone.remoteBuildblocked by private ACR, ACR pull failure due to RBAC propagation delay, Container Apps returning 404 from JumpBox / App Gateway.After
azd upcompletes end-to-end in bothbasicandailz-integratedmodes:Testing
Verified
azd up(provision+deploy) from scratch ontest006andtest007inailz-integratedmode.basicmodeazd upre-validated — no regressions introduced.Related Documentation
ChangeDetails.md— fix-by-fix breakdown (12 items) with root cause analysis, before/after code, and impact per deployment mode.infra/README.md— updated deployment instructions for bothbasicandailz-integratedmodes.Breaking Changes
None for
basicmode.For
ailz-integratedmode:existingQueuePrivateDnsZoneIdis now a recognized parameter inmain.parameters.json. If the AILZ resource group already has aprivatelink.queue.core.windows.netDNS zone, set this value before runningazd provisionto enable the DNS zone group for the queue private endpoint. If left empty, provisioning still succeeds — the DNS zone group is simply skipped until the zone is available.Notes
privatelink.queue.core.windows.netin the AILZ resource group. Item 12 ensures the parameter flows correctly once the zone exists.predeployreadiness gate (item 10) is configurable:ACR_RBAC_TIMEOUTandACR_RBAC_STABILIZATIONenv vars.