Use undashed UUIDs for skin profile requests#802
Open
laroon-lili wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the undashed UUID form when requesting player profile data from the Mojang session server in
MojangSkinProvider.Why
The session profile endpoint commonly expects UUIDs without hyphens. Using
UUID.toString()sends the dashed form, which can fail with Yggdrasil-compatible/session-server implementations that only accept the canonical undashed profile id format. In that case BlueMap cannot download the skin and never writes the playerhead asset.This keeps BlueMap's internal UUID handling and playerhead asset names unchanged; it only normalizes the UUID for the outbound session profile request.
Testing
v5.7codebase with Java 21:./gradlew :neoforge:release --no-daemon