Fix: App crash when double click on port profile#3382
Merged
mergify[bot] merged 2 commits intomainfrom Apr 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the Port Profiles selection child window triggered by double-clicking a port profile, by ensuring the window code-behind uses the correct view model type.
Changes:
- Update
PortProfilesChildWindowdouble-click handler to castDataContexttoPortProfilesViewModel. - Add
ToDo.mdto.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/NETworkManager/Views/PortProfilesChildWindow.xaml.cs | Fixes incorrect DataContext cast in double-click handler to prevent runtime crash. |
| .gitignore | Ignores ToDo.md in git. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
App crash when double click on port profile
Update changelog to reflect this changes