Batch delete#217
Open
shroffk wants to merge 8 commits into
Open
Conversation
|
Collaborator
Author
|
@jacomago I had to update one of your Integration tests. I think it makes sense for this to be 400 since this is a bad request (a null channel name) |
tynanford
previously approved these changes
May 8, 2026
jacomago
reviewed
May 11, 2026
|
|
||
| assertDoesNotThrow(() -> channelService.create("ch", channel)); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Could do with repository layer tests as well.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to PR #214
I removed the 404 error
I made this end point "best effort", the response is the number of channels Cf successfully deleted.