refactor(server): merge announce + udpbcast into announcer.py#163
Merged
Conversation
jacomago
approved these changes
May 13, 2026
The two files were small, always imported together, and split a single UDP subsystem across two modules. Merging them into announcer.py (named after the main class) also removes the name shadow with protocol/announce.py. SharedUDPServer was never imported anywhere and is dropped.
anderslindho
force-pushed
the
refactor/merge-udp-announcer
branch
from
87818d7 to
8cf832c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two files were small, always imported together, and split a single UDP subsystem across two modules. Merging them into
announcer.py(named after the main class) also removes the name shadow withprotocol/announce.py.SharedUDPServerwas never imported anywhere and is dropped.