refactor: Make DeleteItemsRequest and QueryItemsRequest constructor parameters optional with null defaults, simplifying test calls.

Author: CodeWithKyrian

src/Requests/DeleteItemsRequest.php

@@ -13,9 +13,9 @@ class DeleteItemsRequest
      * @param array<string, string> $whereDocument Optional query condition to filter items to delete based on document content.
      */
     public function __construct(
-        public readonly ?array $ids,
-        public readonly ?array $where,
-        public readonly ?array $whereDocument,
+        public readonly ?array $ids = null,
+        public readonly ?array $where = null,
+        public readonly ?array $whereDocument = null,
     ) {}
 
     public static function fromArray(array $data): self

src/Requests/QueryItemsRequest.php

@@ -15,11 +15,11 @@ class QueryItemsRequest
      * @param string[] $include Optional list of items to include in the response.
      */
     public function __construct(
-        public readonly ?array $where,
-        public readonly ?array $whereDocument,
-        public readonly ?array $queryEmbeddings,
-        public readonly ?int   $nResults,
-        public readonly ?array $include,
+        public readonly ?array $where = null,
+        public readonly ?array $whereDocument = null,
+        public readonly ?array $queryEmbeddings = null,
+        public readonly ?int   $nResults = null,
+        public readonly ?array $include = null,
     ) {}
 
     public static function fromArray(array $data): self

tests/Feature/ApiTest.php

@@ -5,7 +5,6 @@
 namespace Codewithkyrian\ChromaDB\Tests\Feature;
 
 use Codewithkyrian\ChromaDB\ChromaDB;
-use Codewithkyrian\ChromaDB\Exceptions\ChromaException;
 use Codewithkyrian\ChromaDB\Exceptions\InvalidArgumentException;
 use Codewithkyrian\ChromaDB\Exceptions\NotFoundException;
 use Codewithkyrian\ChromaDB\Exceptions\UniqueConstraintException;
@@ -18,7 +17,6 @@
 use Codewithkyrian\ChromaDB\Requests\QueryItemsRequest;
 use Codewithkyrian\ChromaDB\Requests\UpdateCollectionRequest;
 use Codewithkyrian\ChromaDB\Requests\UpdateItemsRequest;
-use Codewithkyrian\ChromaDB\Requests\UpdateTenantRequest;
 
 beforeEach(function () {
     $this->api = ChromaDB::factory()
@@ -264,12 +262,6 @@
 
     $items = $this->api->getCollectionItems($collection->id, 'default_database', 'default_tenant', new GetEmbeddingRequest(
         ids: ['id1'],
-        where: null,
-        whereDocument: null,
-        sort: null,
-        limit: null,
-        offset: null,
-        include: []
     ));
     expect($items->ids)->toContain('id1')
         ->and($items->ids)->not->toContain('id2');
@@ -289,9 +281,6 @@
     $query = $this->api->queryCollectionItems($collection->id, 'default_database', 'default_tenant', new QueryItemsRequest(
         queryEmbeddings: [[1.1, 2.2]],
         nResults: 1,
-        where: null,
-        whereDocument: null,
-        include: []
     ));
     expect($query->ids[0])->toContain('id1');
 });
@@ -351,8 +340,6 @@
 
     $this->api->deleteCollectionItems($collection->id, 'default_database', 'default_tenant', new DeleteItemsRequest(
         ids: ['id1'],
-        where: null,
-        whereDocument: null
     ));
     $count = $this->api->countCollectionItems($collection->id, 'default_database', 'default_tenant');
     expect($count)->toBe(1);