Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Data Group#1172
Open
Seti-Jemal wants to merge 11 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Data Group#1172Seti-Jemal wants to merge 11 commits intoCodeYourFuture:mainfrom
Seti-Jemal wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
changed the title
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Seti-Jemal
added
the
Needs Review
cjyuan
reviewed
Apr 4, 2026
| console.log(`${recipe.title} serves ${recipe.serves} | ||
| ingredients: | ||
| ${recipe}`); | ||
| ${recipe.ingredients.join('\n ')}`); |
Contributor
There was a problem hiding this comment.
Why place two extra space in the separator?
Author
There was a problem hiding this comment.
Because I thought it would error but it didn't , it showed "[ object Object]" so I used join() to put ingredients on new lines.
Contributor
There was a problem hiding this comment.
I mean, why use recipe.ingredients.join('\n ') and not recipe.ingredients.join('\n')?
Author
There was a problem hiding this comment.
It just from writing mistake.
| let total = 0; | ||
|
|
||
| for (const [coin, quantity] of Object.entries(till)) { | ||
| const value = parseInt(coin); |
Contributor
There was a problem hiding this comment.
Can you explain why you choose to use parseInt(coin) instead of Number(coin)?
Author
There was a problem hiding this comment.
I used parseInt because it gets the number from a string like "50", but Number() would give NaN.
Contributor
There was a problem hiding this comment.
Both parseInt("50") and Number("50")produce 50 though. Can you elaborate?
Author
There was a problem hiding this comment.
Yeah that works for 50, both parseInt and Number give 50. But my coins are like 50p, so pareseInt works because it read the number at the start and ignores the 'p'. Number(50p) would return NaN because it tries to convert the whole string and fails.
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
Contributor
|
All good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have answered the task as required.