Skip to content

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| quote generator app #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandru-pocovnicu wants to merge 13 commits into
base: main
Choose a base branch
from
Open

London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| quote generator app #984

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
df37abd
update title
alexandru-pocovnicu Mar 8, 2026
31fcc7d
Add functionality to display a random quote on page load
alexandru-pocovnicu Mar 9, 2026
670779a
add button functionality for new quotes
alexandru-pocovnicu Mar 9, 2026
0015e40
replace pickFromArray with direct random selection from quotes array
alexandru-pocovnicu Mar 9, 2026
be903f2
Add auto-play functionality to display quotes at intervals
alexandru-pocovnicu Mar 9, 2026
17571ba
Fix HTML doctype and add auto-generate toggle checkbox
alexandru-pocovnicu Mar 9, 2026
ea60dd5
Refactor quote selection logic into a reusable function and update ev…
alexandru-pocovnicu Mar 9, 2026
405bec9
Refactor quote selection to use pickFromArray for improved randomness
alexandru-pocovnicu Mar 20, 2026
828dc03
Fix null checks for quote and author elements and refactor interval v…
alexandru-pocovnicu Mar 20, 2026
f41fe77
Use textContent instead of innerText for quote and author elements
alexandru-pocovnicu Mar 20, 2026
da857e3
Fix formatting and improve readability in chooseQuote function
alexandru-pocovnicu Apr 12, 2026
a17fc2b
Fix formatting and spacing in auto-generate event listener
alexandru-pocovnicu Apr 12, 2026
e0c8d35
delete unnecessary code
alexandru-pocovnicu Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<script defer src="quotes.js"></script>
</head>
<body>
<label>
<input type="checkbox" id="auto-play-toggle" />Auto-generate
</label>
<h1>hello there</h1>
<p id="quote"></p>
<p id="author"></p>
Expand Down
26 changes: 26 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,29 @@ const quotes = [
];

// call pickFromArray with the quotes array to check you get a random quote

function chooseQuote() {
const randomQuote = quotes[Math.floor(Math.random() * quotes.length)];
Copy link
Copy Markdown

@takanocap takanocap Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welldone you have done a good job just a few things:
can we make the line easy to understand research KISS and SOC and DRY. can we do something to avoid repeating the line 496? its used in line 20 too

Copy link
Copy Markdown
Author

@alexandru-pocovnicu alexandru-pocovnicu Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you


const quote = document.getElementById("quote");
quote.innerText = randomQuote.quote;
Copy link
Copy Markdown

@takanocap takanocap Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use textContent instead of innerText and why ?
what happens if quote is null ?


const author = document.getElementById("author");
author.innerText = randomQuote.author;
}

window.addEventListener("load", chooseQuote);

const button = document.getElementById("new-quote");
button.addEventListener("click", chooseQuote);

const autoGenerate = document.getElementById("auto-play-toggle");
let interval = null;
autoGenerate.addEventListener("change", () => {
if (autoGenerate.checked) {
interval = setInterval(chooseQuote, 2000);
Copy link
Copy Markdown

@takanocap takanocap Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what doeas 2000 mean? what are magic numbers ? and how can we handle magic numbers ?

} else {
clearInterval(interval);
interval = null;
Copy link
Copy Markdown

@kyle-tightest kyle-tightest Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line may not be necessary, try removing it and see if it works?

Copy link
Copy Markdown
Author

@alexandru-pocovnicu alexandru-pocovnicu Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which line? the "if" starts the interval and without the "else" the interval doesn't stop even after the box is unchecked

Copy link
Copy Markdown

@kyle-tightest kyle-tightest Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line that this comment is on, line 521 which says interval = null;

Copy link
Copy Markdown
Author

@alexandru-pocovnicu alexandru-pocovnicu Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
});
Loading