Fix TSV reader losing empty string values in provenance/metadata/rescoring dicts#147
Merged
Conversation
…oring dicts Empty TSV cells were converted to None at parse time, then stored directly into sub-dicts after the str(v) coercion was removed in 4044a55. Pydantic rejects None where dict[str, str] is expected. Fix: restore empty string for provenance and metadata values; coerce to NaN for rescoring features.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 71.97% 72.01% +0.03%
==========================================
Files 32 32
Lines 3247 3248 +1
==========================================
+ Hits 2337 2339 +2
+ Misses 910 909 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty TSV cells were converted to None at parse time, then stored directly into sub-dicts after the
str(v)coercion was removed in 4044a55. Pydantic rejectsNonewheredict[str, str]is expected. Fix: restore empty string for provenance and metadata values; coerce to NaN for rescoring features.Fixes #145.