fix: address second round of Copilot review feedback

- Sort htmlFiles for deterministic search index output
- Bound final section to book content, excluding script/footer
- Add aria-label to search input for accessibility
- Skip h2 headings without id in sub-section TOC generation
- Use ruby-version-file in CI to match .ruby-version
- Use npm ci for reproducible CI builds
- Use YAML.safe_load_file instead of YAML.load_file
- Update engines.node to >=16.0.0 (required by grunt 1.6.1)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: piti6

.github/workflows/deploy-web.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version-file: '.ruby-version'
           bundler-cache: true
 
       - name: Setup Node.js
@@ -34,7 +34,7 @@ jobs:
           cache: 'npm'
 
       - name: Install npm dependencies
-        run: npm install --ignore-scripts
+        run: npm ci --ignore-scripts
 
       - name: Build web pages (JP + EN)
         run: npm run web

articles/layouts/layout-web.html.erb

@@ -34,7 +34,7 @@
         <a href="#" class="lang-btn" data-lang="en">English</a>
       </div>
       <div class="search-box">
-        <input type="text" id="search-input" placeholder="Search..." autocomplete="off" />
+        <input type="text" id="search-input" placeholder="Search..." autocomplete="off" aria-label="Search" />
         <div id="search-results" class="search-results"></div>
       </div>
       <%= @toc %>
@@ -111,6 +111,7 @@
       subUl.className = 'toc-sub';
       headings.forEach(function(h2) {
         var id = h2.getAttribute('id');
+        if (!id) return;
         var text = h2.textContent.replace(/^\s+/, '');
         var subLi = document.createElement('li');
         var subA = document.createElement('a');

articles/lib/tasks/z01_pandoc2review.rake

@@ -32,7 +32,7 @@ end
 
 desc 'run pandoc2review'
 task :pandoc2review do
-  config = YAML.load_file(CONFIG_FILE, permitted_classes: [Date])
+  config = YAML.safe_load_file(CONFIG_FILE, permitted_classes: [Date])
   if config['contentdir'] == '_refiles'
     path = '_refiles'
     p2r = 'pandoc2review'

build-search-index.js

@@ -9,7 +9,7 @@ const path = require("path");
 const webroot = process.argv[2] || path.join(__dirname, "articles", "webroot");
 const outFile = path.join(webroot, "search-index.json");
 
-const htmlFiles = fs.readdirSync(webroot).filter(f => f.endsWith(".html") && f !== "index.html" && f !== "titlepage.html");
+const htmlFiles = fs.readdirSync(webroot).filter(f => f.endsWith(".html") && f !== "index.html" && f !== "titlepage.html").sort();
 
 const index = [];
 
@@ -39,7 +39,8 @@ htmlFiles.forEach(file => {
     // Index each section — use positions from full html since headings were matched against it
     for (let i = 0; i < headings.length; i++) {
       const start = headings[i].pos;
-      const end = i + 1 < headings.length ? headings[i + 1].pos : html.length;
+      const naviPos = html.indexOf('<nav class="book-navi');
+      const end = i + 1 < headings.length ? headings[i + 1].pos : (naviPos !== -1 ? naviPos : html.length);
       const sectionHtml = html.slice(start, end);
       const text = stripTags(sectionHtml).slice(0, 500);
       sections.push({

package.json

@@ -14,7 +14,7 @@
   },
   "homepage": "https://github.com/CyberAgentGameEntertainment/UnityPerformanceTuningBible/blob/main/README.md",
   "engines": {
-    "node": ">=6.0.0"
+    "node": ">=16.0.0"
   },
   "scripts": {
     "global-bundler": "gem install bundler",