Skip to content

Commit 6b2899d

Browse files
committed
minor refactoring
1 parent b9a4196 commit 6b2899d

5 files changed

Lines changed: 24 additions & 18 deletions

File tree

java/src/main/java/com/cybersource/ws/client/PoolingHttpClientConnection.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -323,17 +323,23 @@ public boolean retryRequest(IOException exception, int executionCount, HttpConte
323323
return false;
324324
}
325325

326-
HttpClientContext httpClientContext = HttpClientContext.adapt(httpContext);
327-
if (!httpClientContext.isRequestSent() && exception instanceof NoHttpResponseException) {
328-
System.out.println("retrying as it NoHttpResponseException and request is not sent");
329-
return true;
330-
}
331-
332326
if (exception instanceof NoHttpResponseException) {
333327
System.out.println("not retrying as it is NoHttpResponseException and request is sent");
334328
return false;
335329
}
336330

331+
// if (exception instanceof NoHttpResponseException) {
332+
// System.out.println("retrying as it NoHttpResponseException and request is not sent");
333+
// return true;
334+
// }
335+
//
336+
// if (exception instanceof java.net.SocketException && (exception.getMessage().equalsIgnoreCase("Connection reset") ||
337+
// exception.getLocalizedMessage().equalsIgnoreCase("Connection reset"))) {
338+
//
339+
// System.out.println("retrying for connection reset");
340+
// return true;
341+
// }
342+
HttpClientContext httpClientContext = HttpClientContext.adapt(httpContext);
337343
if (!httpClientContext.isRequestSent()) {
338344
try {
339345
Thread.sleep(retryWaitInterval);

java/src/main/resources/cybs.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ useHttpClient=false
2121
useHttpClientWithConnectionPool=false
2222
# Following configure parameters will only work with useHttpClientWithConnectionPool=true
2323
# Optional parameters, default values configured in application
24-
maxConnections=200
25-
defaultMaxConnectionsPerRoute=200
26-
maxConnectionsPerRoute=200
24+
maxConnections=1000
25+
defaultMaxConnectionsPerRoute=1000
26+
maxConnectionsPerRoute=1000
2727
connectionRequestTimeoutMs=1000
2828
connectionTimeoutMs=2000
2929
socketTimeoutMs=2000

java/src/test/resources/test_cybs.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ useHttpClientWithConnectionPool=false
2121
# Following configure parameters will only work with useHttpClientWithConnectionPool=true
2222
# Optional parameters, default values configured in application
2323
enabledShutdownHook=true
24-
maxConnections=200
25-
defaultMaxConnectionsPerRoute=200
26-
maxConnectionsPerRoute=200
24+
maxConnections=1000
25+
defaultMaxConnectionsPerRoute=1000
26+
maxConnectionsPerRoute=1000
2727
connectionRequestTimeoutMs=1000
2828
connectionTimeoutMs=2000
2929
socketTimeoutMs=2000

samples/nvp/cybs.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ useHttpClientWithConnectionPool=false
2222
# Following configure parameters will only work with useHttpClientWithConnectionPool=true
2323
# Optional parameters, default values configured in application
2424
enabledShutdownHook=true
25-
maxConnections=200
26-
defaultMaxConnectionsPerRoute=200
27-
maxConnectionsPerRoute=200
25+
maxConnections=1000
26+
defaultMaxConnectionsPerRoute=1000
27+
maxConnectionsPerRoute=1000
2828
connectionRequestTimeoutMs=1000
2929
connectionTimeoutMs=2000
3030
socketTimeoutMs=2000

samples/xml/cybs.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ useHttpClientWithConnectionPool=false
2222
# Following configure parameters will only work with useHttpClientWithConnectionPool=true
2323
# Optional parameters, default values configured in application
2424
enabledShutdownHook=true
25-
maxConnections=200
26-
defaultMaxConnectionsPerRoute=200
27-
maxConnectionsPerRoute=200
25+
maxConnections=1000
26+
defaultMaxConnectionsPerRoute=1000
27+
maxConnectionsPerRoute=1000
2828
connectionRequestTimeoutMs=1000
2929
connectionTimeoutMs=2000
3030
socketTimeoutMs=2000

0 commit comments

Comments
 (0)