Skip to content

Add py.typed#186

Merged
thodson-usgs merged 4 commits into
DOI-USGS:mainfrom
JEFuller:py-typed
Dec 18, 2025
Merged

Add py.typed#186
thodson-usgs merged 4 commits into
DOI-USGS:mainfrom
JEFuller:py-typed

Conversation

@davetapley
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davetapley, I think we should configure this in the pyproject.toml instead. Something like

[tool.setuptools.package-data]
dataretrieval = ["py.typed"]

We need to add the py.typed before this PR will work, right?

@thodson-usgs thodson-usgs mentioned this pull request Dec 3, 2025
@davetapley
Copy link
Copy Markdown
Contributor Author

@thodson-usgs good catch! Updated.

Copy link
Copy Markdown
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the suggested change, then I approve. Thanks, @davetapley

Comment thread setup.py Outdated
Co-authored-by: Timothy Hodson <34148978+thodson-usgs@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with it!

@thodson-usgs thodson-usgs merged commit 7298d3b into DOI-USGS:main Dec 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants