fix(formatter): use primitive type instead of schema name in get_response_type#3723
Open
walidcavelius wants to merge 1 commit intomasterfrom
Open
fix(formatter): use primitive type instead of schema name in get_response_type#3723walidcavelius wants to merge 1 commit intomasterfrom
walidcavelius wants to merge 1 commit intomasterfrom
Conversation
…onse_type When a named component schema has a primitive type (e.g. type: string), get_response_type() used schema_name() directly, emitting the schema name as a class type and adding a model import — but no class is generated for primitive schemas, causing a compile error in generated examples. Fix: check simple_type() first; if the schema resolves to a primitive, use that type and suppress the model import. Consistent with how type_to_java() already guards against this case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
walidcavelius
added
the
changelog/Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a named component schema has a primitive type (e.g.
type: string),get_response_type()usedschema_name()directly — emitting the schema name as a class type and generating a model import (com.datadog.api.client.v2.model.<SchemaName>). But no class is generated for primitive schemas, causing a compile error in generated examples.Example:
ConvertCatalogEntityResponse: {type: string}caused the example to importcom.datadog.api.client.v2.model.ConvertCatalogEntityResponsewhich doesn't exist.Fix
Check
simple_type()first — if the schema resolves to a primitive (String,Long, etc.), use that type directly and suppress the model import. Consistent with howtype_to_java()already guards against this case.Test plan