fix(train): move GitStatusChecker out of module level to prevent Dock…#144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
GitStatusCheckerwas instantiated and executed at module level intrain.py:This caused two issues:
git fetchfails inside containers that have no git remote, no SSH keys, or nogitbinary. Becausesubprocess.runusescheck=True, it raisesCalledProcessErrorand kills the process before training starts.anomavision.train(includingcli.pybuilding the argument parser for--help) would trigger a network call unconditionally.Fix
Moved the git check inside
main()with two additional guards:checker.is_repo())try/exceptso a git failure never blocks trainingImpact
Testing
anomavision train --helpworks inside Docker without errorsanomavision train --config config.ymlruns successfully