Addressing bug reported at https://github.com/DesignLiquido/xslt-processor/issues/183.#185
Merged
leonelsanchesdasilva merged 2 commits intomainfrom Mar 19, 2026
Merged
Addressing bug reported at https://github.com/DesignLiquido/xslt-processor/issues/183.#185leonelsanchesdasilva merged 2 commits intomainfrom
leonelsanchesdasilva merged 2 commits intomainfrom
Conversation
Coverage report
Test suite run success650 tests passing in 64 suites. Report generated by 🧪jest coverage report action from fe4fe14 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage and adjusts default template application so templates can match nested elements (issue #183) when no explicit root template matches.
Changes:
- Add tests covering
match="//message"for nested and non-nested XML structures. - Simplify the “no template matched root context” branch to use
applyBuiltInTemplate(...). - Update the
src/xpath/libsubmodule pointer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/xslt/issue-183.test.ts | Adds regression tests for nested template matching scenarios from issue #183. |
| src/xslt/xslt.ts | Replaces manual child/grandchild traversal with a call to the built-in template application helper. |
| src/xpath/lib | Updates the XPath submodule revision used by the processor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #183.