fix(imports): extract imports from Svelte and Vue script blocks#224
Open
jmcmacnz wants to merge 1 commit intoDeusData:mainfrom
Open
fix(imports): extract imports from Svelte and Vue script blocks#224jmcmacnz wants to merge 1 commit intoDeusData:mainfrom
jmcmacnz wants to merge 1 commit intoDeusData:mainfrom
Conversation
Owner
|
Hey, thanks for building this. Will review ASAP once I am back on the 15th :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223
Summary
<script>blocks in.svelteand.vuefilesscript_element -> raw_textcontent with the JavaScript grammar and reuse the existing ES import walkerWhy
Svelte and Vue files are discovered and parsed, but their root AST is markup-oriented rather than plain JS/TS. Imports live inside
document -> script_element -> raw_text, so they never reached the normal ES import extraction path.Validation
scripts/build.shsrc/App.sveltenow produces 7IMPORTSedges to relative imports including:src/components/TopNavigation.sveltesrc/components/TreeView.sveltesrc/components/AdCanvas.svelte$lib/...and@/...still remain unresolved, which is expected and out of scope for this PR