chore: Include all ports in system compose file#1540
Merged
Conversation
The ports are not required when they're not being forwarded but including them means there is one place to look to figure out which server is running where.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 43 43
Lines 3205 3205
=======================================
Hits 3056 3056
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shree-iyengar-dls
approved these changes
May 15, 2026
Contributor
shree-iyengar-dls
left a comment
shree-iyengar-dls
left a comment
There was a problem hiding this comment.
This is helpful thanks thanks
Contributor
Author
|
@ZohebShaikh This doesn't affect anything if the port is being mapped to itself, right? |
Contributor
|
This shouldn't hurt but they are not required because they are on network host. Another option is to just add them as comments because I think you are just trying to document them ? |
ZohebShaikh
approved these changes
May 15, 2026
tpoliaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ports are not required when they're not being forwarded but
including them means there is one place to look to figure out which
service is running where.