Add fastcs eiger to i15-1#2058
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## update_dodal_ophyd_async_v0.17a1 #2058 +/- ##
===================================================================
Coverage ? 99.05%
===================================================================
Files ? 325
Lines ? 12673
Branches ? 0
===================================================================
Hits ? 12553
Misses ? 120
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DominicOram
added a commit
that referenced
this pull request
May 18, 2026
* WIP-Updates-some-imports-and-names * Update trigger logic * Remove Merlin device as it is now in ophyd-async * Fix b16 * Shorten imports * Convert Tetramm detector * update electron analyser * Remove commissioning junfrau * Add electron analyser detector logic * remove _get_value * Finish up tests for electron analyser * Update p99 to use AndorDetector rather than Andor2Detector * Update b21 * Fix beamlines * Update i19-2 * Fix mythen * Fix i22 saxs test * Remove i24 import CommissioningJungfrau * Attempt to fix dodal plans for eiger * Update electron analyser detector doc string * Correct eiger plan * partial test conversion * tests: amend fastcs eiger test to use new signals * tests: amend pattern generator in conftest * chore: bump ophyd-async version * test: amend test assertion and mock tetram * tests: relax test shutter type signature * tests: add tiff and tetram tests to fix codecov * Remove commented out code * Fix eiger PV prefixes * Add initial fix for tetramm * Fix tetramm as tested on beamline * Use our own logic for tetramm * Convert commissioning Jungfrau * Add fastcs eiger to i15-1 (#2058) * Add link to Allow ADHDFDataLogic driver to be specified as a NDArrayBaseIO issue * Add jungfrau tests * Add tests for single trigger detector --------- Co-authored-by: gkalua <jyv15736@pc0139.cs.diamond.ac.uk> Co-authored-by: Oli Wenman <Oliver.Wenman@diamond.ac.uk> Co-authored-by: Jacob Williamson <jacob.williamson@diamond.ac.uk> Co-authored-by: Shihab Suliman <shihab.suliman@diamond.ac.uk> Co-authored-by: Dominic Oram <dominic.oram@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fastcs eiger to i15-1. Needs the new ophyd async version so based on top of #1979
Instructions to reviewer on how to test:
dodal connect i15-1fastcs_eigerconnectsChecks for reviewer
dodal connect ${BEAMLINE}