Skip to content

Add error extensions to AuthError#275

Merged
shree-iyengar-dls merged 8 commits into
mainfrom
add_error_extensions
May 15, 2026
Merged

Add error extensions to AuthError#275
shree-iyengar-dls merged 8 commits into
mainfrom
add_error_extensions

Conversation

@shree-iyengar-dls
Copy link
Copy Markdown
Contributor

Improving numtracker auth error messages

@shree-iyengar-dls shree-iyengar-dls requested a review from tpoliaw May 8, 2026 14:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.44%. Comparing base (a25367f) to head (2359409).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   76.35%   76.44%   +0.08%     
==========================================
  Files          13       13              
  Lines        1937     1944       +7     
==========================================
+ Hits         1479     1486       +7     
  Misses        458      458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw
Copy link
Copy Markdown
Collaborator

tpoliaw commented May 8, 2026

Looks good but could do with a couple of tests to make sure the errors look as expected.

And numtracker doesn't use conventional commits

@shree-iyengar-dls
Copy link
Copy Markdown
Contributor Author

Yup, just adding some tests now

Copy link
Copy Markdown
Collaborator

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a test (probably in graphql/mod.rs?) to check that the code is added to the extensions when the auth check is called via a graphql query? I think we need to be calling extend() somewhere so I'm not sure the extensions are doing anything yet.

Most of the other comments are code-style things - the change itself looks ok.

Comment thread src/graphql/auth.rs Outdated
Comment thread src/graphql/auth.rs Outdated
Comment thread src/graphql/auth.rs
Comment thread src/graphql/auth.rs Outdated
Comment thread src/graphql/auth.rs Outdated
Comment thread src/graphql/auth.rs Outdated
Comment thread src/graphql/auth.rs
tpoliaw
tpoliaw previously approved these changes May 15, 2026
Copy link
Copy Markdown
Collaborator

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you if you want to change the tests

Comment thread src/graphql/mod.rs Outdated
@tpoliaw tpoliaw dismissed their stale review May 15, 2026 13:24

duplicate tests in auth.rs not needed

@tpoliaw tpoliaw changed the title refactor: Add error extensions to AuthError Add error extensions to AuthError May 15, 2026
@shree-iyengar-dls shree-iyengar-dls added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 6acb104 May 15, 2026
7 checks passed
@shree-iyengar-dls shree-iyengar-dls deleted the add_error_extensions branch May 15, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants