Fix module build on CentOS 9 and 10#561
Open
richgieg wants to merge 2 commits intoDisplayLink:mainfrom
Open
Conversation
Contributor
|
FYI @elguero, please approve. |
elguero
suggested changes
Apr 19, 2026
Contributor
elguero
left a comment
elguero
left a comment
There was a problem hiding this comment.
This is a good addition. It will allow us to know ahead of time what is coming into EL distros. When those changes land for EL, we just need to change the CENTOS flag to EL in those conditionals.
| endif | ||
|
|
||
| ifneq (,$(findstring centos,$(ID))) | ||
| CENTOSFLAG := -DCENTOS$(VERSION_ID) |
Contributor
There was a problem hiding this comment.
I would suggest setting the version the same way that it is being done above on line 12
-DCENTOS$(shell echo $(VERSION_ID) | cut -d. -f1)
Otherwise, the flag looks like this -DEL9 -DCENTOS"9" or -DEL9 -DCENTOS"10"
Contributor
There was a problem hiding this comment.
Also, I tested this patch against CentOS Stream 9 and 10.
Author
There was a problem hiding this comment.
Thank you @elguero for your review! I added a commit with the requested change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evdi module build fails on CentOS Stream 9 and 10 due to some 6.17 kernel changes being backported. This PR adds a CENTOSFLAG to differentiate from ELFLAG because CentOS Stream runs ahead of the other EL kernels (Rocky Linux, AlmaLinux, RHEL) and they don't have the same changes backported yet.
I suppose when the time comes to add the defined(EL9) and defined(EL10) checks for the 6.17 changes to evdi_drm_drv.h and evdi_fb.c, then the defined(CENTOS9) and defined(CENTOS10) checks can be removed because CentOS Stream 9 and 10 also trigger the EL9 and EL10 flags, respectively. But it wouldn't hurt to leave them either.