Round bounds before calling changeColBounds

[Opt-Mucca]

Spotted this while going through HPresolve: If you pass model->col_lower or model->col_upper to changeColBounds then it will not perform the tightening based on potential integrality upgrades because the < > condition isn't satisfied. I think we're then not updating some bounds that we could have been tightening.

Other option: Add something like bool force to changeColBounds for these cases. (if there's a strong preference to make sure integer rounding is only done in one spot)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (9d3c86f) to head (67dad81).
⚠️ Report is 18 commits behind head on latest.

Additional details and impacted files

@@            Coverage Diff             @@
##           latest    #2963      +/-   ##
==========================================
- Coverage   81.28%   81.27%   -0.01%     
==========================================
  Files         358      358              
  Lines       88720    88675      -45     
==========================================
- Hits        72119    72074      -45     
  Misses      16601    16601              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fwesselm]

Spotted this while going through HPresolve: If you pass model->col_lower or model->col_upper to changeColBounds then it will not perform the tightening based on potential integrality upgrades because the < > condition isn't satisfied. I think we're then not updating some bounds that we could have been tightening.

Other option: Add something like bool force to changeColBounds for these cases. (if there's a strong preference to make sure integer rounding is only done in one spot)

Thanks for checking the presolve code, @Opt-Mucca!

I am confused (as usual); could you tell me which condition would prevent rounding of the bounds?

[Opt-Mucca]

Ahhhhhhhhhh. You're not confused, I was just reading the function wrong...... My bad.