Skip to content

invoice: fix false BROKEN log in cmp_rr_number when sort self-compares #9153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nGoline wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

invoice: fix false BROKEN log in cmp_rr_number when sort self-compares #9153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lightningd/invoice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,9 +606,12 @@ static int cmp_rr_number(const struct routehint_candidate *a,
if (a->c->rr_number < b->c->rr_number)
return -1;

/* They're unique, so can't be equal */
log_broken(ld->log, "Two equal candidates %p and %p, channels %p and %p, rr_number %"PRIu64" and %"PRIu64,
a, b, a->c, b->c, a->c->rr_number, b->c->rr_number);
/* rr_numbers are unique per channel; equal means same channel.
* Some qsort implementations (notably macOS) compare an element
* with itself, so a->c == b->c is expected and not a bug. */
if (a->c != b->c)
log_broken(ld->log, "Two equal candidates %p and %p, channels %p and %p, rr_number %"PRIu64" and %"PRIu64,
a, b, a->c, b->c, a->c->rr_number, b->c->rr_number);
return 0;
}

Expand Down
Loading