CHANGELOG.md: put missing CHANGELOG entries in for PR 9136.#9160
Merged
rustyrussell merged 1 commit intoMay 21, 2026
Merged
Conversation
Removals should be documented with Changelog-Removed lines, mirroring the old Deprecated line. In this case, the `max_total_htlc_in_msat` removal was premature: we try to give one version AFTER the deprecation period. That way users can re-enable the feature if they need to, using `--i-promise-to-fix-broken-api-user=listpeerchannels.max_total_htlc_in_msat` and we can decide whether to defer removal, re-enable, even un-deprecate (or get whatever tool they are using fixed). It's happened a few times in the past that nobody tested with deprecations disabled, and users got stuck when they upgraded :( Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removals should be documented with Changelog-Removed lines, mirroring the old Deprecated line.
In this case, the
max_total_htlc_in_msatremoval was premature: we try to give one version AFTER the deprecation period.That way users can re-enable the feature if they need to, using
--i-promise-to-fix-broken-api-user=listpeerchannels.max_total_htlc_in_msatand we can decide whether to defer removal, re-enable, even un-deprecate (or get whatever tool they are using fixed).It's happened a few times in the past that nobody tested with deprecations disabled, and users got stuck when they upgraded :(
Changelog-None