Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/ingestors/taxila/rdnl_ingestor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,13 @@ def process_rdnl(url)
event.start = event.start.change(year: Time.now.year + 1)
event.end = event.end.change(year: Time.now.year + 1)
end

event.description = event_data.css('.card__excerpt > p')[0].text.strip

event.venue = event_data.css('dl.meta-list > div > dd')[1].text.strip

sleep(1) unless Rails.env.test? and File.exist?('test/vcr_cassettes/ingestors/lcrdm.yml')
event_page2 = Nokogiri::HTML5.parse(open_url(event.url.to_s, raise: true)).css('.entry__inner')
event.cost_basis = 'charge' if event_page2.text.include?('€')

event.source = 'RDNL'
event.host_institutions = ['RDNL']
event.timezone = 'Amsterdam'
Expand Down
19 changes: 10 additions & 9 deletions test/unit/ingestors/taxila/rdnl_ingestor_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,23 @@ class RDNLIngestorTest < ActiveSupport::TestCase
ingestor = Ingestors::Taxila::RdnlIngestor.new

# check event doesn't
new_title = 'Essentials 4 Data Support, Feb/Mar 2026'
new_url = 'https://researchdata.nl/agenda/essentials-4-data-support-feb-mar-2026/'
new_title = 'Essentials 4 Data Support, april/juni 2026 (NL)'
new_url = 'https://researchdata.nl/agenda/essentials-4-data-support-april-juni-2026/'
refute Event.where(title: new_title, url: new_url).any?

# run task
assert_difference 'Event.count', 1 do
freeze_time(2025) do
assert_difference 'Event.count', 2 do
freeze_time(2026) do
VCR.use_cassette('ingestors/rdnl') do
ingestor.read(source.url)
ingestor.write(@user, @content_provider)
end
end
end

assert_equal 1, ingestor.events.count
assert_equal 2, ingestor.events.count
assert ingestor.materials.empty?
assert_equal 1, ingestor.stats[:events][:added]
assert_equal 2, ingestor.stats[:events][:added]
assert_equal 0, ingestor.stats[:events][:updated]
assert_equal 0, ingestor.stats[:events][:rejected]

Expand All @@ -51,8 +51,9 @@ class RDNLIngestorTest < ActiveSupport::TestCase
# check other fields
assert_equal 'RDNL', event.source
assert_equal 'Amsterdam', event.timezone
assert_equal 'DANS-KNAW', event.venue
assert_equal Time.zone.parse('Tue, 10 Feb 2026 09:00:00.000000000 UTC +00:00'), event.start
assert_equal Time.zone.parse('Mon, 26 Mar 2026 17:00:00.000000000 UTC +00:00'), event.end
assert_equal 'SURF, Health-RI', event.venue
assert_equal Time.zone.parse('Mon, 16 Apr 2026 09:00:00.000000000 UTC +00:00'), event.start
assert_equal Time.zone.parse('Fri, 4 Jun 2026 17:00:00.000000000 UTC +00:00'), event.end
assert_equal 'charge', event&.cost_basis
end
end
126 changes: 122 additions & 4 deletions test/vcr_cassettes/ingestors/rdnl.yml

Large diffs are not rendered by default.

Loading