fix(splash) + chore(security): blessed splash fix + npm supply-chain cooldown + 3.3.1#21
Open
decentraliser wants to merge 3 commits into
Open
fix(splash) + chore(security): blessed splash fix + npm supply-chain cooldown + 3.3.1#21decentraliser wants to merge 3 commits into
decentraliser wants to merge 3 commits into
Conversation
Splash subprocess used `node -e require('blessed')` with stdio inherit. Module resolution starts from cwd, so running emblemai from a directory whose node_modules tree lacks blessed (e.g. ~/repositories/claw-os/) leaked a `Cannot find module 'blessed'` stack trace to stderr. Auth still completed (parent try/catch swallowed the throw), but the noise misled operators and AI agents into thinking auth failed.
Set child cwd to the script directory so require() always resolves the bundled blessed dep, and ignore child stderr so any future failure stays cosmetic.
L3-37 Claude
…e-age Hardening against the Shai-Hulud / TanStack npm+PyPI supply-chain wave. - add .npmrc: minimum-release-age=10080 (7d cooldown) + save-exact - pin all 13 third-party direct deps to exact resolved versions; kept @emblemvault/* deps as ranges - regenerate package-lock.json (synced) - npm audit: 5 pre-existing transitive advisories (2 high) — left for a separate pass L3-37 Claude
L3-37 Claude
decentraliser
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined PR. Subsumes #23 (closed).
Changes
fix(splash): resolve blessed from script dir, suppress child stderr(5883d3c)Original PR #21 content.
chore(security): npm supply-chain cooldown — pin deps + .npmrc release-age(55c861a)Hardening against the Shai-Hulud / TanStack npm+PyPI supply-chain wave.
.npmrc:minimum-release-age=10080(7d cooldown, enforced by npm 11+) +save-exact@emblemvault/*kept as^package-lock.jsonchore(release): 3.3.1 — supply-chain cooldown(68b1e97)Version bump for the publish after merge.
Caveats
npm audit: 5 pre-existing transitive advisories (2 high) — not addressed.Test plan
npm ci && npm run typecheck && npm testnpm publish(@emblemvault/agentwallet@3.3.1)