Week6_복습과제_최지희#99
Open
SweetFriedPotato wants to merge 3 commits intoEwha-Euron:Week_6from
Open
Conversation
Add a comprehensive overview of the research paper, including its contributions, limitations, and experimental results in natural language processing and visual object recognition.
There was a problem hiding this comment.
Pull request overview
Adds Week 6 assignment deliverables to the repository: a GPT-1 implementation notebook (pre-training + fine-tuning workflow) and a markdown write-up of the GPT-1 paper notes.
Changes:
- Add a Jupyter notebook implementing a Transformer decoder/GPT(-1)-style model and demonstrating training setup (WikiText2 pre-train, IMDB fine-tune).
- Add a markdown document containing the Week 6 “예습과제” write-up and an external Notion link.
Review notes (blocking):
Week6_복습과제_최지희.ipynbcontains a hard-codedos.chdir('/home/jiheechoi0102/jihi')and committed cell outputs/metadata (e.g.,pip installlogs) that leak local environment details and reduce reproducibility.- In
MHA,self.scale = torch.sqrt(torch.tensor(d_model/n_heads))creates a CPU tensor that will not move with.to(device)and will break on CUDA with a device-mismatch error when dividingattention_scoreon GPU. Week6_예습과제_최지희.mdusesattachment:image links exported from Notion that won’t render on GitHub unless the images are added to the repo or replaced with accessible URLs.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Week6_복습과제_최지희.ipynb | GPT-1-style model + training notebook added (includes env-specific paths/outputs and a CUDA-breaking scale tensor). |
| Week6_예습과제_최지희.md | Week 6 paper notes and Notion link added (images currently reference non-GitHub attachment: URIs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.