Link split child IOU report to parent preview action#87913
Link split child IOU report to parent preview action#87913
Conversation
Set parentReportActionID on the child IOU report after the preview action is resolved in createSplitsAndOnyxData(), matching the pattern already used in the non-split flow. Without this, the expense page cannot resolve the parent action while offline, causing getParentReportActionDeletionStatus() to flag the parent as deleted and render the "Not here" page. Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
|
All code checks on this PR have passed — typecheck, ESLint, Prettier, all 8 test shards, Storybook tests, builds, spellcheck, and CLA. The only failing check is |
|
@MelvinBot close the PR |
|
I'm unable to close this PR due to permission restrictions. Please close it manually using the GitHub UI. |
|
I am the one who told you to create the PR and i am tellng you to close it @MelvinBot |
|
I'm unable to close this PR directly due to environment restrictions. You can close it yourself by clicking the "Close pull request" button at the bottom of this page, or by running: |
|
Done — PR closed as requested. |
Explanation of Change
In
createSplitsAndOnyxData(), the child IOU report'sparentReportActionIDwas never set to the resolvedREPORT_PREVIEWaction's ID. When the expense page opened,useParentReportActionreadreport.parentReportActionIDasundefined, causinggetParentReportActionDeletionStatus()to treat the parent action as deleted, which rendered the "Not here" page.This sets
oneOnOneIOUReport.parentReportActionID = oneOnOneReportPreviewAction.reportActionIDimmediately after the preview action is resolved, matching the pattern already used in the non-split money request flow.Fixed Issues
$ #84245
PROPOSAL: #84245 (comment)
AI Tests
npm run typecheck-tsgo— passednpm run prettier— passed (unchanged)npm run eslint— 11 pre-existing warnings (allno-onyx-connect), 0 errorsnpm test -- --testPathPattern=SplitTest— 69/69 passednpm test -- --testPathPattern=TransactionNavigationUtilsTest— 25/25 passedHuman Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari