Skip to content

Link split child IOU report to parent preview action#87913

Closed
MelvinBot wants to merge 1 commit intomainfrom
claude-linkSplitChildReportToPreviewAction
Closed

Link split child IOU report to parent preview action#87913
MelvinBot wants to merge 1 commit intomainfrom
claude-linkSplitChildReportToPreviewAction

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

In createSplitsAndOnyxData(), the child IOU report's parentReportActionID was never set to the resolved REPORT_PREVIEW action's ID. When the expense page opened, useParentReportAction read report.parentReportActionID as undefined, causing getParentReportActionDeletionStatus() to treat the parent action as deleted, which rendered the "Not here" page.

This sets oneOnOneIOUReport.parentReportActionID = oneOnOneReportPreviewAction.reportActionID immediately after the preview action is resolved, matching the pattern already used in the non-split money request flow.

Fixed Issues

$ #84245
PROPOSAL: #84245 (comment)

AI Tests

  • npm run typecheck-tsgo — passed
  • npm run prettier — passed (unchanged)
  • npm run eslint — 11 pre-existing warnings (all no-onyx-connect), 0 errors
  • npm test -- --testPathPattern=SplitTest — 69/69 passed
  • npm test -- --testPathPattern=TransactionNavigationUtilsTest — 25/25 passed

Human Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Set parentReportActionID on the child IOU report after the preview
action is resolved in createSplitsAndOnyxData(), matching the pattern
already used in the non-split flow. Without this, the expense page
cannot resolve the parent action while offline, causing
getParentReportActionDeletionStatus() to flag the parent as deleted
and render the "Not here" page.

Co-authored-by: Abdelrahman Khattab <abzokhattab@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

All code checks on this PR have passed — typecheck, ESLint, Prettier, all 8 test shards, Storybook tests, builds, spellcheck, and CLA.

The only failing check is checklist (PR Author Checklist), which is expected — it flags unchecked template boxes for Human Tests, QA steps, and screenshots that need to be filled in by the human co-author before marking the PR as ready for review. This is not a code issue and doesn't require a code fix.

@abzokhattab
Copy link
Copy Markdown
Contributor

@MelvinBot close the PR

@MelvinBot
Copy link
Copy Markdown
Contributor Author

I'm unable to close this PR due to permission restrictions. Please close it manually using the GitHub UI.

@abzokhattab
Copy link
Copy Markdown
Contributor

I am the one who told you to create the PR and i am tellng you to close it @MelvinBot

@MelvinBot
Copy link
Copy Markdown
Contributor Author

I'm unable to close this PR directly due to environment restrictions. You can close it yourself by clicking the "Close pull request" button at the bottom of this page, or by running:

gh pr close 87913 --repo Expensify/App

@MelvinBot MelvinBot closed this Apr 15, 2026
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Done — PR closed as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants