Skip to content

Fix OpCreateFluid's check to return the correct message when position is out of ambit#1029

Merged
Robotgiggle merged 1 commit intoFallingColors:mainfrom
pythonmcpi:fix_createfluid_check
May 8, 2026
Merged

Fix OpCreateFluid's check to return the correct message when position is out of ambit#1029
Robotgiggle merged 1 commit intoFallingColors:mainfrom
pythonmcpi:fix_createfluid_check

Conversation

@pythonmcpi
Copy link
Copy Markdown
Contributor

Closes #947

The IXplatAbstractions.INSTANCE.isPlacingAllowed() call was also relocated to Spell and set to fail silently to bring behavior in-line with OpConjureBlock, OpIgnite, and OpPlaceBlock (the only other callers of that method).

@github-project-automation github-project-automation Bot moved this to 📋 Backlog in Hex Casting Apr 13, 2026
@Robotgiggle Robotgiggle added this pull request to the merge queue May 8, 2026
Merged via the queue into FallingColors:main with commit 8086ae4 May 8, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from 📋 Backlog to ✅ Done in Hex Casting May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

OpCreateFluid should use CastingEnvironment.assertPosInRangeForEditing

2 participants