TreeList for asymptotically-efficient immutable lists [part 1: Thoth's]#1031
Merged
object-Object merged 10 commits intoFallingColors:mainfrom May 6, 2026
Merged
TreeList for asymptotically-efficient immutable lists [part 1: Thoth's]#1031object-Object merged 10 commits intoFallingColors:mainfrom
object-Object merged 10 commits intoFallingColors:mainfrom
Conversation
TreeList is an immutable collection ported from Scala's Vector class
Co-authored-by: Alwinfy <20421383+Alwinfy@users.noreply.github.com>
Member
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
Mostly LGTM! Comments are mostly cleanups for maintainability, and suggestions to reduce addon breakage
Member
There was a problem hiding this comment.
For transparency - I mostly just skimmed this file, don't have the energy to review 3300 lines of Java right now. General notes:
- Would it be worth bulk replacing the various instances of
vector/VectorwithtreeList/TreeListrespectively, or at least the public ones? - Can the various public members be moved to the top of their classes so it's easier for consumers to see what methods are available?
- Could maybe use more doc comments on public members
- Very optional, but some unit tests might be nice if it's not too much effort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #804
Conflicts with #897
This is part 1, part 2 will change ListIota to use TreeList, part 3 will change the VM to use TreeList for the stack.