Fix Turnstile script firing callback before DOM loaded#7
Open
connordufault wants to merge 1 commit into
Open
Conversation
|
Thank you for your contribution. My colleague will review this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When "Explicit Consent" is disabled in the field settings for the Turnstile field, the Turnstile script loads and fires the callback function before the DOM has fully loaded. Since the DOM hasn't fully loaded yet, the
document.getElementById("cf_turnstile")inonloadTurnstileCallback()returnsnulland Turnstile fails to render with the errorUncaught TurnstileError: [Cloudflare Turnstile] Invalid type for parameter "container", expected "string" or an implementation of "HTMLElement".This PR sets the
deferattribute on the Turnstile script tag so that it does not execute until the DOM is fully loaded.Fixes #6