Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/remote/inet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3121,7 +3121,9 @@ static bool packet_receive(rem_port* port, UCHAR* buffer, SSHORT buffer_length,
INET_force_error = 1;
try
{
inet_error(false, port, "simulated error - read", isc_net_read_err);
// function inet_error as 5 parameters
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not put all stuff into single PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was approved earlier.
#8882..
I don't understand why this change was repeated here...
and how to remove it from here :(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example create new fresh branch and cherry-pick required commits from this branch.

// inet_error(bool releasePort, rem_port* port, const TEXT* function, ISC_STATUS operation, int status)
inet_error(false, port, "simulated error - read", isc_net_read_err, 0);
}
catch (const Exception&) { }
return false;
Expand Down