Skip to content

Bump ananas#949

Merged
tomusdrw merged 2 commits into
mainfrom
td-ananas
Apr 22, 2026
Merged

Bump ananas#949
tomusdrw merged 2 commits into
mainfrom
td-ananas

Conversation

@tomusdrw
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1cf96a7f-ce34-4ab6-b2b1-f69ae8deb532

📥 Commits

Reviewing files that changed from the base of the PR and between cd0590d and 42ea17a.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • bin/lib/package.json
✅ Files skipped from review due to trivial changes (1)
  • bin/lib/package.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the dependency @fluffylabs/anan-as to ^1.3.0 across relevant packages for improved compatibility and stability.

Walkthrough

Updated the dependency specification for @fluffylabs/anan-as from ^1.1.5 to ^1.3.0 in two package manifest files: packages/core/pvm-interpreter-ananas/package.json and bin/lib/package.json. No other fields, scripts, exports, or public declarations were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • skoszuta
  • DrEverr

Poem

I hopped through package.json glades,
nudged a version, fixed the shades,
from 1.1.5 to 1.3.0 I sped,
carrots and CI nod in bed 🥕✨
— a rabbit's small deploy-time tread

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the reason for the dependency bump and any compatibility or feature changes introduced.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Bump ananas' directly describes the main change: updating the @fluffylabs/anan-as dependency version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-ananas

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/core/pvm-interpreter-ananas/package.json`:
- Line 7: The `@fluffylabs/anan-as` dependency has mismatched versions across
package.json files; update every occurrence of the dependency
"@fluffylabs/anan-as" to a single uniform version (e.g., set all to "^1.3.0") so
all package.json manifests use the same version; locate the dependency entries
in each package.json and replace the differing version strings (such as "^1.1.5"
and "^1.3.0") with the chosen canonical version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7341bdb1-61c4-4ae1-b6d9-f0be8ce167a2

📥 Commits

Reviewing files that changed from the base of the PR and between 1fbacf3 and cd0590d.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • packages/core/pvm-interpreter-ananas/package.json

Comment thread packages/core/pvm-interpreter-ananas/package.json
@tomusdrw
Copy link
Copy Markdown
Member Author

@fluffylabs-bot benchmark

@fluffylabs-bot
Copy link
Copy Markdown
Contributor

fluffylabs-bot Bot commented Apr 22, 2026

Benchmark workflow triggered successfully! 🎉
Requested by: @tomusdrw
PR number: #949
Target repository: FluffyLabs/typeberry-testing

🔗 Check the Actions tab for workflow progress.

@fluffylabs-bot
Copy link
Copy Markdown
Contributor

fluffylabs-bot Bot commented Apr 22, 2026

Picofuzz Benchmark Results

fallback

Metric @typeberry/jam@0.5.11 Current Difference
min 3.71ms 3.66ms ≈ -0.05ms (-1.37%)
mean 5.45ms 5.55ms ≈ +0.10ms (+1.82%)
p90 7.67ms 7.72ms ≈ +0.05ms (+0.67%)
p99 10.93ms 9.97ms ≈ -0.96ms (-8.81%)

safrole

Metric @typeberry/jam@0.5.11 Current Difference
min 3.82ms 4.06ms ≈ +0.24ms (+6.20%)
mean 13.60ms 13.32ms ≈ -0.28ms (-2.06%)
p90 23.56ms 23.55ms ≈ -0.01ms (-0.06%)
p99 37.27ms 29.11ms 🟢 -8.16ms (-21.91%)

storage

Metric @typeberry/jam@0.5.11 Current Difference
min 4.89ms 4.41ms ≈ -0.47ms (-9.70%)
mean 30.95ms 28.69ms ≈ -2.26ms (-7.30%)
p90 64.71ms 57.47ms 🟢 -7.23ms (-11.18%)
p99 93.28ms 78.42ms 🟢 -14.87ms (-15.94%)

storage_light

Metric @typeberry/jam@0.5.11 Current Difference
min 6.02ms 6.44ms ≈ +0.42ms (+6.98%)
mean 20.37ms 19.64ms ≈ -0.74ms (-3.61%)
p90 33.30ms 30.70ms ≈ -2.60ms (-7.81%)
p99 42.38ms 39.50ms ≈ -2.89ms (-6.81%)

🤖 Automated benchmark

@github-actions
Copy link
Copy Markdown

View all
File Benchmark Ops
bytes/hex-from.ts[0] parse hex using Number with NaN checking 64185.39 ±2.06% 86.17% slower
bytes/hex-from.ts[1] parse hex from char codes 464037.46 ±0.39% fastest ✅
bytes/hex-from.ts[2] parse hex from string nibbles 268815.41 ±0.34% 42.07% slower
bytes/hex-to.ts[0] number toString + padding 91762.24 ±0.5% fastest ✅
bytes/hex-to.ts[1] manual 7490.34 ±0.51% 91.84% slower
codec/bigint.compare.ts[0] compare custom 96395526.93 ±4.81% 1.17% slower
codec/bigint.compare.ts[1] compare bigint 97540910.34 ±4.55% fastest ✅
codec/bigint.decode.ts[0] decode custom 73493148.15 ±2.68% 21.03% slower
codec/bigint.decode.ts[1] decode bigint 93069127.36 ±4.65% fastest ✅
codec/decoding.ts[0] manual decode 9315788.49 ±2.75% 86.37% slower
codec/decoding.ts[1] int32array decode 66137501.87 ±3.09% 3.25% slower
codec/decoding.ts[2] dataview decode 68362514.22 ±3.35% fastest ✅
codec/encoding.ts[0] manual encode 1087261.1 ±0.7% 13.11% slower
codec/encoding.ts[1] int32array encode 1251278.97 ±0.39% fastest ✅
codec/encoding.ts[2] dataview encode 1232467.44 ±0.31% 1.5% slower
collections/map-set.ts[0] 2 gets + conditional set 71626.73 ±0.15% fastest ✅
collections/map-set.ts[1] 1 get 1 set 47699.84 ±0.08% 33.4% slower
logger/index.ts[0] console.log with string concat 5018937.02 ±44.45% fastest ✅
logger/index.ts[1] console.log with args 213858.22 ±123.5% 95.74% slower
math/add_one_overflow.ts[0] add and take modulus 69580460.64 ±50.2% 27.42% slower
math/add_one_overflow.ts[1] condition before calculation 95860686.15 ±4.37% fastest ✅
math/count-bits-u32.ts[0] standard method 45608219.23 ±2% 51.86% slower
math/count-bits-u32.ts[1] magic 94733218.44 ±4.08% fastest ✅
math/count-bits-u64.ts[0] standard method 5021979.92 ±0.65% 81.27% slower
math/count-bits-u64.ts[1] magic 26809008.09 ±1.21% fastest ✅
math/mul_overflow.ts[0] multiply and bring back to u32 100736602.52 ±5% 0.72% slower
math/mul_overflow.ts[1] multiply and take modulus 101462403.65 ±4.48% fastest ✅
math/switch.ts[0] switch 98472308.25 ±4.82% fastest ✅
math/switch.ts[1] if 96565403.88 ±5.72% 1.94% slower
hash/index.ts[0] hash with numeric representation 68.42 ±0.06% 31.21% slower
hash/index.ts[1] hash with string representation 41.4 ±2.46% 58.38% slower
hash/index.ts[2] hash with symbol representation 66.75 ±0.35% 32.89% slower
hash/index.ts[3] hash with uint8 representation 76.44 ±0.17% 23.14% slower
hash/index.ts[4] hash with packed representation 99.46 ±0.24% fastest ✅
hash/index.ts[5] hash with bigint representation 73.5 ±0.07% 26.1% slower
hash/index.ts[6] hash with uint32 representation 93.25 ±0.22% 6.24% slower
bytes/bytes-to-number.ts[0] Conversion with bitops 3701.56 ±6.06% fastest ✅
bytes/bytes-to-number.ts[1] Conversion without bitops 2769.7 ±4.68% 25.17% slower
bytes/compare.ts[0] Comparing Uint32 bytes 11010.99 ±0.21% fastest ✅
bytes/compare.ts[1] Comparing raw bytes 10903.96 ±0.13% 0.97% slower
codec/view_vs_collection.ts[0] Get first element from Decoded 14863.14 ±0.68% 51.75% slower
codec/view_vs_collection.ts[1] Get first element from View 30801.53 ±0.43% fastest ✅
codec/view_vs_collection.ts[2] Get 50th element from Decoded 14687.85 ±0.54% 52.31% slower
codec/view_vs_collection.ts[3] Get 50th element from View 16005.58 ±0.31% 48.04% slower
codec/view_vs_collection.ts[4] Get last element from Decoded 14819.21 ±0.15% 51.89% slower
codec/view_vs_collection.ts[5] Get last element from View 10908.68 ±0.36% 64.58% slower
codec/view_vs_object.ts[0] Get the first field from Decoded 197810.09 ±1.5% 4.33% slower
codec/view_vs_object.ts[1] Get the first field from View 49054.64 ±0.37% 76.28% slower
codec/view_vs_object.ts[2] Get the first field as view from View 48207.3 ±0.72% 76.68% slower
codec/view_vs_object.ts[3] Get two fields from Decoded 202982.24 ±0.52% 1.83% slower
codec/view_vs_object.ts[4] Get two fields from View 38508.61 ±0.4% 81.38% slower
codec/view_vs_object.ts[5] Get two fields from materialized from View 76361.98 ±0.37% 63.07% slower
codec/view_vs_object.ts[6] Get two fields as views from View 38512.82 ±0.39% 81.37% slower
codec/view_vs_object.ts[7] Get only third field from Decoded 206764.43 ±0.35% fastest ✅
codec/view_vs_object.ts[8] Get only third field from View 47577.17 ±0.39% 76.99% slower
codec/view_vs_object.ts[9] Get only third field as view from View 47507.64 ±0.34% 77.02% slower
collections/map_vs_sorted.ts[0] Map 137705.41 ±0.18% fastest ✅
collections/map_vs_sorted.ts[1] Map-array 47227.38 ±0.12% 65.7% slower
collections/map_vs_sorted.ts[2] Array 54944.95 ±0.2% 60.1% slower
collections/map_vs_sorted.ts[3] SortedArray 84043.85 ±0.17% 38.97% slower
collections/hash-dict-vs-blob-dict_delete.ts[0] StringHashDictionary 2600.72 ±0.41% 0.51% slower
collections/hash-dict-vs-blob-dict_delete.ts[1] BlobDictionary(1) 2613.97 ±0.42% fastest ✅
collections/hash-dict-vs-blob-dict_delete.ts[2] BlobDictionary(2) 2613.65 ±0.35% 0.01% slower
collections/hash-dict-vs-blob-dict_delete.ts[3] BlobDictionary(3) 2612.8 ±0.4% 0.04% slower
collections/hash-dict-vs-blob-dict_delete.ts[4] BlobDictionary(4) 2601.08 ±0.43% 0.49% slower
collections/hash-dict-vs-blob-dict_delete.ts[5] BlobDictionary(5) 2607.98 ±0.37% 0.23% slower
collections/hash-dict-vs-blob-dict_get.ts[0] StringHashDictionary 2980.65 ±0.29% fastest ✅
collections/hash-dict-vs-blob-dict_get.ts[1] BlobDictionary(1) 2925.72 ±0.35% 1.84% slower
collections/hash-dict-vs-blob-dict_get.ts[2] BlobDictionary(2) 2913.47 ±0.34% 2.25% slower
collections/hash-dict-vs-blob-dict_get.ts[3] BlobDictionary(3) 2903.57 ±0.3% 2.59% slower
collections/hash-dict-vs-blob-dict_get.ts[4] BlobDictionary(4) 2928.77 ±0.34% 1.74% slower
collections/hash-dict-vs-blob-dict_get.ts[5] BlobDictionary(5) 2830.86 ±1.19% 5.03% slower
collections/hash-dict-vs-blob-dict_set.ts[0] StringHashDictionary 2376.6 ±0.31% fastest ✅
collections/hash-dict-vs-blob-dict_set.ts[1] BlobDictionary(1) 2366.15 ±0.29% 0.44% slower
collections/hash-dict-vs-blob-dict_set.ts[2] BlobDictionary(2) 2357.64 ±0.32% 0.8% slower
collections/hash-dict-vs-blob-dict_set.ts[3] BlobDictionary(3) 2331.05 ±0.39% 1.92% slower
collections/hash-dict-vs-blob-dict_set.ts[4] BlobDictionary(4) 2264.16 ±2.79% 4.73% slower
collections/hash-dict-vs-blob-dict_set.ts[5] BlobDictionary(5) 2330.33 ±0.42% 1.95% slower
hash/blake2b.ts[0] our hasher 1.08 ±0.18% fastest ✅
hash/blake2b.ts[1] blake2b js 0.03 ±0.35% 97.22% slower
crypto/ed25519.ts[0] native crypto 5.714 ±0.93% fastest ✅
crypto/ed25519.ts[1] wasm lib 2.285 ±0.23% 60.01% slower
crypto/ed25519.ts[2] wasm lib batch 2.281 ±0.22% 60.08% slower

Benchmarks summary: 83/83 OK ✅

@tomusdrw tomusdrw merged commit bfd4e60 into main Apr 22, 2026
14 checks passed
@tomusdrw tomusdrw deleted the td-ananas branch April 22, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant