Skip to content

Update node requirement in readme#950

Merged
tomusdrw merged 2 commits into
mainfrom
td-readme
Apr 22, 2026
Merged

Update node requirement in readme#950
tomusdrw merged 2 commits into
mainfrom
td-readme

Conversation

@tomusdrw
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a9068207-901a-4cd6-be91-6296e6973909

📥 Commits

Reviewing files that changed from the base of the PR and between 7f43c4b and 7128418.

📒 Files selected for processing (1)
  • README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated the Node.js version requirement in the project requirements from v22.9.0 to v24.0.0. This change clarifies the supported runtime and helps ensure the project is run with a more current Node.js release, reducing potential environment-related issues for contributors and deploys.

Walkthrough

The pull request updates the documented Node.js version example in README.md's "Requirements" section from v22.9.0 to v24.0.0. No other content or command snippets were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Update readme #612: Earlier PR that bumped the README Node.js example to v22.9.0; this PR continues the version upgrade to v24.0.0.

Suggested reviewers

  • mateuszsikora

Poem

🐰 Hop, hop — a tiny change I cheer,
From twenty-two to twenty-four we steer.
A README line, simple and bright,
I nibble digits through the night.
Version bumped — a joyful sight! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, which fails the basic requirement for meaningful documentation of changes. Add a description explaining why the Node version requirement was updated and any relevant context or breaking changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating the Node version requirement in the README from v22.9.0 to v24.0.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-readme

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomusdrw
Copy link
Copy Markdown
Member Author

@fluffylabs-bot benchmark

@fluffylabs-bot
Copy link
Copy Markdown
Contributor

fluffylabs-bot Bot commented Apr 22, 2026

Benchmark workflow triggered successfully! 🎉
Requested by: @tomusdrw
PR number: #950
Target repository: FluffyLabs/typeberry-testing

🔗 Check the Actions tab for workflow progress.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Line 42: Fix the spacing typo in the version string by replacing the incorrect
"v 24.0.0" token with the standard "v24.0.0" token; locate the occurrence of "v
24.0.0" in the README and remove the space so the version follows Node.js
format.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 310b6fba-e676-482b-a164-19ff3bcfb5ec

📥 Commits

Reviewing files that changed from the base of the PR and between 1fbacf3 and 7f43c4b.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

View all
File Benchmark Ops
bytes/hex-from.ts[0] parse hex using Number with NaN checking 65397.4 ±0.78% 85.14% slower
bytes/hex-from.ts[1] parse hex from char codes 440208.1 ±0.61% fastest ✅
bytes/hex-from.ts[2] parse hex from string nibbles 248280.25 ±1.47% 43.6% slower
bytes/hex-to.ts[0] number toString + padding 88257.24 ±0.55% fastest ✅
bytes/hex-to.ts[1] manual 7287.85 ±0.86% 91.74% slower
codec/bigint.compare.ts[0] compare custom 87009923.09 ±5.22% fastest ✅
codec/bigint.compare.ts[1] compare bigint 85028778.49 ±5.8% 2.28% slower
codec/bigint.decode.ts[0] decode custom 60897729.73 ±4.38% 20.89% slower
codec/bigint.decode.ts[1] decode bigint 76978113.43 ±6.57% fastest ✅
codec/decoding.ts[0] manual decode 9749451.49 ±1.16% 86.69% slower
codec/decoding.ts[1] int32array decode 65964479.19 ±3.14% 9.93% slower
codec/decoding.ts[2] dataview decode 73233645.95 ±3.85% fastest ✅
codec/encoding.ts[0] manual encode 1093804.29 ±0.51% 13.1% slower
codec/encoding.ts[1] int32array encode 1258660.96 ±0.35% fastest ✅
codec/encoding.ts[2] dataview encode 1210557.21 ±0.96% 3.82% slower
collections/map-set.ts[0] 2 gets + conditional set 69106.07 ±0.24% fastest ✅
collections/map-set.ts[1] 1 get 1 set 46608.72 ±0.57% 32.55% slower
logger/index.ts[0] console.log with string concat 4810427.09 ±40.65% fastest ✅
logger/index.ts[1] console.log with args 1261252.45 ±83.55% 73.78% slower
math/add_one_overflow.ts[0] add and take modulus 66825833.55 ±54.86% 30.7% slower
math/add_one_overflow.ts[1] condition before calculation 96429403.9 ±5.88% fastest ✅
math/count-bits-u32.ts[0] standard method 34882787.91 ±1.91% 59.06% slower
math/count-bits-u32.ts[1] magic 85196643.76 ±4.41% fastest ✅
math/count-bits-u64.ts[0] standard method 358917.24 ±0.56% 87.43% slower
math/count-bits-u64.ts[1] magic 2854310 ±0.57% fastest ✅
math/mul_overflow.ts[0] multiply and bring back to u32 98283535.35 ±5.07% fastest ✅
math/mul_overflow.ts[1] multiply and take modulus 91438140.34 ±5.65% 6.96% slower
math/switch.ts[0] switch 87091715.26 ±6.18% fastest ✅
math/switch.ts[1] if 81757127.48 ±6.6% 6.13% slower
hash/index.ts[0] hash with numeric representation 57.13 ±2.5% 31.94% slower
hash/index.ts[1] hash with string representation 35.02 ±3.6% 58.28% slower
hash/index.ts[2] hash with symbol representation 57.67 ±2.55% 31.3% slower
hash/index.ts[3] hash with uint8 representation 63.34 ±2.64% 24.54% slower
hash/index.ts[4] hash with packed representation 83.94 ±2.4% fastest ✅
hash/index.ts[5] hash with bigint representation 65.07 ±2.3% 22.48% slower
hash/index.ts[6] hash with uint32 representation 79.41 ±2.05% 5.4% slower
bytes/bytes-to-number.ts[0] Conversion with bitops 2791.7 ±4.82% fastest ✅
bytes/bytes-to-number.ts[1] Conversion without bitops 2386.44 ±3.45% 14.52% slower
bytes/compare.ts[0] Comparing Uint32 bytes 9386.24 ±2.77% 12.21% slower
bytes/compare.ts[1] Comparing raw bytes 10691.83 ±0.52% fastest ✅
codec/view_vs_collection.ts[0] Get first element from Decoded 14680.2 ±0.62% 53.47% slower
codec/view_vs_collection.ts[1] Get first element from View 31552.23 ±0.54% fastest ✅
codec/view_vs_collection.ts[2] Get 50th element from Decoded 14788.2 ±0.61% 53.13% slower
codec/view_vs_collection.ts[3] Get 50th element from View 17063.41 ±0.71% 45.92% slower
codec/view_vs_collection.ts[4] Get last element from Decoded 14697.67 ±0.98% 53.42% slower
codec/view_vs_collection.ts[5] Get last element from View 11694.77 ±1.18% 62.94% slower
codec/view_vs_object.ts[0] Get the first field from Decoded 193291.45 ±0.88% 1.69% slower
codec/view_vs_object.ts[1] Get the first field from View 48326.3 ±1.24% 75.42% slower
codec/view_vs_object.ts[2] Get the first field as view from View 49913.89 ±0.65% 74.61% slower
codec/view_vs_object.ts[3] Get two fields from Decoded 192410.37 ±1.26% 2.14% slower
codec/view_vs_object.ts[4] Get two fields from View 39918.77 ±0.6% 79.7% slower
codec/view_vs_object.ts[5] Get two fields from materialized from View 78456.99 ±0.69% 60.1% slower
codec/view_vs_object.ts[6] Get two fields as views from View 39389.79 ±1.44% 79.97% slower
codec/view_vs_object.ts[7] Get only third field from Decoded 196617.42 ±0.6% fastest ✅
codec/view_vs_object.ts[8] Get only third field from View 27044.78 ±85.34% 86.24% slower
codec/view_vs_object.ts[9] Get only third field as view from View 46900.25 ±1.82% 76.15% slower
collections/map_vs_sorted.ts[0] Map 121692.6 ±0.75% fastest ✅
collections/map_vs_sorted.ts[1] Map-array 40780.04 ±2.9% 66.49% slower
collections/map_vs_sorted.ts[2] Array 50636.36 ±1.68% 58.39% slower
collections/map_vs_sorted.ts[3] SortedArray 66575 ±5.17% 45.29% slower
collections/hash-dict-vs-blob-dict_delete.ts[0] StringHashDictionary 2236.49 ±3.76% 3.87% slower
collections/hash-dict-vs-blob-dict_delete.ts[1] BlobDictionary(1) 2241.22 ±2.79% 3.67% slower
collections/hash-dict-vs-blob-dict_delete.ts[2] BlobDictionary(2) 2233.14 ±2.96% 4.01% slower
collections/hash-dict-vs-blob-dict_delete.ts[3] BlobDictionary(3) 2326.52 ±2.57% fastest ✅
collections/hash-dict-vs-blob-dict_delete.ts[4] BlobDictionary(4) 2277.96 ±2.37% 2.09% slower
collections/hash-dict-vs-blob-dict_delete.ts[5] BlobDictionary(5) 2155.48 ±3.93% 7.35% slower
collections/hash-dict-vs-blob-dict_get.ts[0] StringHashDictionary 2600.24 ±2.87% 16.62% slower
collections/hash-dict-vs-blob-dict_get.ts[1] BlobDictionary(1) 3087.1 ±0.52% 1.01% slower
collections/hash-dict-vs-blob-dict_get.ts[2] BlobDictionary(2) 3114 ±0.36% 0.15% slower
collections/hash-dict-vs-blob-dict_get.ts[3] BlobDictionary(3) 3118.66 ±0.29% fastest ✅
collections/hash-dict-vs-blob-dict_get.ts[4] BlobDictionary(4) 2961.2 ±2.09% 5.05% slower
collections/hash-dict-vs-blob-dict_get.ts[5] BlobDictionary(5) 3064.65 ±0.76% 1.73% slower
collections/hash-dict-vs-blob-dict_set.ts[0] StringHashDictionary 2220.39 ±0.77% fastest ✅
collections/hash-dict-vs-blob-dict_set.ts[1] BlobDictionary(1) 2181.69 ±0.44% 1.74% slower
collections/hash-dict-vs-blob-dict_set.ts[2] BlobDictionary(2) 2190.2 ±0.45% 1.36% slower
collections/hash-dict-vs-blob-dict_set.ts[3] BlobDictionary(3) 2186.46 ±2.14% 1.53% slower
collections/hash-dict-vs-blob-dict_set.ts[4] BlobDictionary(4) 2148.8 ±0.92% 3.22% slower
collections/hash-dict-vs-blob-dict_set.ts[5] BlobDictionary(5) 2175.13 ±0.95% 2.04% slower
hash/blake2b.ts[0] our hasher 0.87 ±3.59% fastest ✅
hash/blake2b.ts[1] blake2b js 0.03 ±5.19% 96.55% slower
crypto/ed25519.ts[0] native crypto 5.61 ±1.17% fastest ✅
crypto/ed25519.ts[1] wasm lib 2.21 ±0.5% 60.61% slower
crypto/ed25519.ts[2] wasm lib batch 2.2 ±0.79% 60.78% slower

Benchmarks summary: 83/83 OK ✅

@tomusdrw
Copy link
Copy Markdown
Member Author

@fluffylabs-bot benchmark

@fluffylabs-bot
Copy link
Copy Markdown
Contributor

Picofuzz Benchmark Results

fallback

Metric @typeberry/jam@0.5.11 Current Difference
min 3.71ms 3.72ms ≈ +0.01ms (+0.20%)
mean 5.45ms 5.58ms ≈ +0.13ms (+2.34%)
p90 7.67ms 7.72ms ≈ +0.05ms (+0.69%)
p99 10.93ms 10.71ms ≈ -0.22ms (-2.04%)

safrole

Metric @typeberry/jam@0.5.11 Current Difference
min 3.82ms 3.99ms ≈ +0.17ms (+4.52%)
mean 13.60ms 13.37ms ≈ -0.23ms (-1.69%)
p90 23.56ms 24.38ms ≈ +0.82ms (+3.47%)
p99 37.27ms 29.38ms 🟢 -7.89ms (-21.16%)

storage

Metric @typeberry/jam@0.5.11 Current Difference
min 4.89ms 4.29ms 🟢 -0.60ms (-12.32%)
mean 30.95ms 30.33ms ≈ -0.61ms (-1.98%)
p90 64.71ms 63.40ms ≈ -1.31ms (-2.02%)
p99 93.28ms 85.12ms ≈ -8.16ms (-8.75%)

storage_light

Metric @typeberry/jam@0.5.11 Current Difference
min 6.02ms 6.46ms ≈ +0.45ms (+7.40%)
mean 20.37ms 20.05ms ≈ -0.33ms (-1.61%)
p90 33.30ms 32.56ms ≈ -0.74ms (-2.23%)
p99 42.38ms 42.87ms ≈ +0.49ms (+1.15%)

🤖 Automated benchmark

@tomusdrw tomusdrw merged commit 7609756 into main Apr 22, 2026
14 checks passed
@tomusdrw tomusdrw deleted the td-readme branch April 22, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant