Code bugs.#505
Merged
Nedelosk merged 9 commits intoForestryMC:master-MC1.12from Apr 6, 2018
Merged
Conversation
Contributor
Author
|
From Idea: |
Contributor
Author
added 3 commits
April 6, 2018 21:18
…ile with empty objects. Improves the use of memory and CPUs
mezz
reviewed
Apr 12, 2018
| public final class EmptyHelper { | ||
| private EmptyHelper() {} | ||
|
|
||
| public static final String EMPTY_STRING = ""; |
Member
There was a problem hiding this comment.
I think this is probably overkill, I'd be surprised if the JVM does not have some kind of optimization for the empty string.
Contributor
Author
There was a problem hiding this comment.
Hm. Probably you are right.
But now I used StringUtils.Empty (as you can see in #504)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first i thought that something is broken, but after some tests I realized that everything work (flower image sizes). So calculation can be removed.
Fuchsia has one section.
Binnie/botany/src/main/java/binnie/botany/genetics/EnumFlowerType.java
Line 50 in 4946c9d
Foxglove - two.
Binnie/botany/src/main/java/binnie/botany/genetics/EnumFlowerType.java
Line 37 in 4946c9d