Skip to content

Commit e4e0dc6

Browse files
uudiingregkh
authored andcommitted
scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()
[ Upstream commit ca4fb89 ] On an error exit path, a negative error code should be returned instead of a positive return value. Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com Fixes: 8777e43 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Cc: Quinn Tran <quinn.tran@cavium.com> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 6bfd875 commit e4e0dc6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/qla2xxx/qla_nvme.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha)
683683
struct nvme_fc_port_template *tmpl;
684684
struct qla_hw_data *ha;
685685
struct nvme_fc_port_info pinfo;
686-
int ret = EINVAL;
686+
int ret = -EINVAL;
687687

688688
if (!IS_ENABLED(CONFIG_NVME_FC))
689689
return ret;

0 commit comments

Comments
 (0)