Skip to content

PoC: Local Scan#55

Draft
henchaves wants to merge 8 commits into
mainfrom
poc/local-scan
Draft

PoC: Local Scan#55
henchaves wants to merge 8 commits into
mainfrom
poc/local-scan

Conversation

@henchaves
Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to perform local vulnerability scans using Python callables as agents. It integrates a new polling mechanism that allows the SDK to communicate with the Hub for agent invocations, enabling a seamless local development and testing workflow for agents. The changes enhance the HelpersResource by providing a unified scan interface for both remote and locally defined agents, abstracting the underlying communication and execution details.

Highlights

  • Local Scan Functionality: Introduced a new scan method within the HelpersResource to support both remote and local agent vulnerability scans. This allows users to provide a Python callable as an agent for local execution.
  • Polling Mechanism for Local Agents: Added a dedicated _poll_scan.py module containing run_poll_scan and arun_poll_scan functions. These functions handle the continuous polling for agent invocation requests from the Hub and submitting responses for local agents.
  • Scan Orchestration: Implemented private helper methods, _scan_remote and _scan_local (with both synchronous and asynchronous versions), to manage the creation and execution flow for different types of agent scans.
  • Utility for Local Scan Body Construction: A new build_local_scan_body function was added to _helpers_types.py to streamline the creation of the request body for local scan initiation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant new feature: local scanning. It allows users to run vulnerability scans on local Python callables, which is a great addition. The implementation involves a new scan method in the helpers, which orchestrates the scan with the Hub and uses a polling mechanism to execute the local agent. The code is well-structured. I've added a few suggestions to improve logging for better debuggability and to simplify a piece of logic for better readability.

Comment thread src/giskard_hub/resources/_poll_scan.py
Comment thread src/giskard_hub/resources/_poll_scan.py
Comment thread src/giskard_hub/resources/helpers.py
Comment thread src/giskard_hub/resources/helpers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant