Gcloud warning (#1512)

* work in progress

* Add gcloud plugin warning

* make pom scanner case sensitive

Author: abbiefarr

plugins/com.google.cloud.tools.eclipse.appengine.validation.test/src/com/google/cloud/tools/eclipse/appengine/validation/PomXmlScannerTest.java

@@ -72,4 +72,23 @@ public void testEndElement() throws SAXException {
     assertEquals(ELEMENT_MESSAGE, message);
   }
 
+  @Test
+  public void testEndElement_gcloudPlugin() throws SAXException {
+    scanner.startElement("", "plugin", "", new AttributesImpl());
+    scanner.startElement("", "groupId", "", new AttributesImpl());
+    String groupId = "com.google.appengine";
+    scanner.characters(groupId.toCharArray(), 0, groupId.length());
+    scanner.endElement("", "groupId", "");
+    assertFalse(scanner.getSaveContents());
+    
+    scanner.startElement("", "artifactId", "", new AttributesImpl());
+    String artifactId = "gcloud-maven-plugin";
+    scanner.characters(artifactId.toCharArray(), 0, artifactId.length());
+    scanner.endElement("", "artifactId", "");
+    assertEquals(1, scanner.getBlacklist().size());
+    
+    String message = scanner.getBlacklist().peek().getMessage();
+    assertEquals(ELEMENT_MESSAGE, message);
+  }
+  
 }

plugins/com.google.cloud.tools.eclipse.appengine.validation/src/com/google/cloud/tools/eclipse/appengine/validation/PomXmlScanner.java

@@ -88,7 +88,8 @@ public void endElement (String uri, String localName, String qName)
     } else if (insidePlugin && "artifactId".equalsIgnoreCase(localName)) {
       // Found closing <artifactId> tag with parent <plugin>
       saveContents = false;
-      if ("appengine-maven-plugin".equalsIgnoreCase(elementContents.toString())) {
+      if ("appengine-maven-plugin".equals(elementContents.toString()) || 
+          "gcloud-maven-plugin".equals(elementContents.toString())) {
         foundArtifactId = true;
       }
     }
@@ -97,7 +98,7 @@ public void endElement (String uri, String localName, String qName)
       // with the same <plugin> parent
       DocumentLocation start = new DocumentLocation(lineNumber, columnNumber - 9);
       String message = Messages.getString("maven.plugin");
-      BannedElement element = new MavenPluginElement(message, start, 9 /*length of <groupId>*/);
+      BannedElement element = new MavenPluginElement(message, start, 0);
       addToBlacklist(element);
       foundAppEngineGroupId = false;
       foundArtifactId = false;

plugins/com.google.cloud.tools.eclipse.appengine.validation/src/com/google/cloud/tools/eclipse/appengine/validation/messages.properties

@@ -2,4 +2,4 @@ application.element=Project ID should be specified at deploy time
 remove.application.element=Remove application element
 web.xml.version=App Engine Standard does not support this servlet version
 convert.servlet=Convert to Java Servlet API 2.5
-maven.plugin=A new App Engine Maven plugin is available
+maven.plugin=This App Engine Maven plugin has been deprecated