Skip to content

Desktop: Refactor window state to not require locking#2928

Merged
timon-schelling merged 6 commits intomasterfrom
refactor_window_state
Jul 24, 2025
Merged

Desktop: Refactor window state to not require locking#2928
timon-schelling merged 6 commits intomasterfrom
refactor_window_state

Conversation

@TrueDoctor
Copy link
Copy Markdown
Member

@TrueDoctor TrueDoctor commented Jul 24, 2025

Partly closes #2541.

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 24, 2025 13:44 Inactive
@timon-schelling
Copy link
Copy Markdown
Member

Getting new error:

[104827:104854:0724/143057.790330:ERROR:gpu/command_buffer/service/shared_image/shared_image_manager.cc:497] SharedImageManager::ProduceMemory: Trying to Produce a Memory representation from a non-existent mailbox.
[104538:104538:0724/143104.119369:ERROR:content/browser/gpu/gpu_process_host.cc:957] GPU process exited unexpectedly: exit_code=133

@timon-schelling
Copy link
Copy Markdown
Member

2025-07-24.14-40-49.mp4

Feels slightly more responsive but also more likely to crash

Comment thread desktop/src/main.rs Outdated
Comment thread desktop/src/app.rs Outdated
Comment thread desktop/src/app.rs Outdated
@timon-schelling
Copy link
Copy Markdown
Member

Otherwise LGTM

@TrueDoctor TrueDoctor force-pushed the refactor_window_state branch from 2673820 to fefac7f Compare July 24, 2025 16:42
@TrueDoctor TrueDoctor enabled auto-merge (squash) July 24, 2025 16:43
@timon-schelling timon-schelling self-requested a review July 24, 2025 16:59
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 24, 2025 16:59 Inactive
@timon-schelling timon-schelling force-pushed the refactor_window_state branch from fefac7f to 569515f Compare July 24, 2025 17:00
@timon-schelling timon-schelling disabled auto-merge July 24, 2025 17:04
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 24, 2025 17:09 Inactive
@timon-schelling timon-schelling enabled auto-merge (squash) July 24, 2025 17:11
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 24, 2025 17:44 Inactive
@timon-schelling timon-schelling merged commit f184e4a into master Jul 24, 2025
4 checks passed
@timon-schelling timon-schelling deleted the refactor_window_state branch July 24, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get the viewport to render beneath the web UI

2 participants