Skip to content

Refactor the 'Round Corners' and 'Auto-Tangents' nodes and vector node unit tests to use Kurbo#2964

Merged
Keavon merged 14 commits intomasterfrom
ir/refactor-v2
Aug 2, 2025
Merged

Refactor the 'Round Corners' and 'Auto-Tangents' nodes and vector node unit tests to use Kurbo#2964
Keavon merged 14 commits intomasterfrom
ir/refactor-v2

Conversation

@indierusty
Copy link
Copy Markdown
Contributor

@indierusty indierusty commented Jul 31, 2025

This PR refactors -

  • 'Round Corners' node
  • 'Auto Tangents'node
  • vector_nodes module unit tests.

Partially Closes #2635

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 31, 2025 15:10 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) July 31, 2025 15:25 Inactive
@Keavon Keavon changed the title Refactor few nodes and unit test in the vector_nodes module to use Kurbo Refactor a few vector nodes and unit tests to use Kurbo Aug 1, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 1, 2025 06:06 Inactive
@Keavon Keavon changed the title Refactor a few vector nodes and unit tests to use Kurbo Refactor the 'Round Corners' and 'Auto-Tangents' nodes and vector node unit tests to use Kurbo Aug 2, 2025
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 2, 2025 05:38 Inactive
@Keavon
Copy link
Copy Markdown
Member

Keavon commented Aug 2, 2025

This branch breaks the Round Corners node when applied to an ellipse.

@Keavon Keavon marked this pull request as draft August 2, 2025 06:00
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 2, 2025 06:04 Inactive
@indierusty indierusty marked this pull request as ready for review August 2, 2025 06:52
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 2, 2025 07:10 Inactive
@Keavon Keavon enabled auto-merge (squash) August 2, 2025 07:35
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 2, 2025 07:36 Inactive
@Keavon Keavon merged commit 037bcb6 into master Aug 2, 2025
4 checks passed
@Keavon Keavon deleted the ir/refactor-v2 branch August 2, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue: Refactor nodes to use Kurbo instead of Bezier-rs

2 participants