Skip to content

Add an error dialog that is displayed if there is an error when exporting artwork#2983

Closed
0HyperCube wants to merge 1 commit intomasterfrom
export-error-dialogue
Closed

Add an error dialog that is displayed if there is an error when exporting artwork#2983
0HyperCube wants to merge 1 commit intomasterfrom
export-error-dialogue

Conversation

@0HyperCube
Copy link
Copy Markdown
Contributor

If an error is encountered during export, the error dialogue should be shown. However currently it is not. This is due to the fact that the export dialogue puts a FrontendMessage::DisplayDialogDismiss after running the exporting process, causing the error to be immediately dismissed.

Also

  • refactor preferences message handler to reduce duplication
  • remove some unnecessary allocations

@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 3, 2025 21:40 Inactive
@0HyperCube 0HyperCube force-pushed the export-error-dialogue branch from 7dfa5d4 to df304b7 Compare August 4, 2025 20:08
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 4, 2025 20:12 Inactive
@0HyperCube 0HyperCube mentioned this pull request Aug 7, 2025
@Keavon Keavon changed the title Display error dialogue when exporting Add an error dialog that is displayed if there is an error when exporting artwork Aug 18, 2025
@0HyperCube
Copy link
Copy Markdown
Contributor Author

There is very little advantage to this PR.

@0HyperCube 0HyperCube closed this Sep 20, 2025
@0HyperCube 0HyperCube reopened this Oct 27, 2025
@0HyperCube 0HyperCube closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant