Desktop: Viewport bounds from viewport container#2989
Merged
timon-schelling merged 3 commits intomasterfrom Aug 4, 2025
Merged
Desktop: Viewport bounds from viewport container#2989timon-schelling merged 3 commits intomasterfrom
timon-schelling merged 3 commits intomasterfrom
Conversation
timon-schelling
changed the title
TrueDoctor
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2970
Use query selector
[data-viewport-container]instead of[data-viewport]because it is available even with hole punching enabled.I also removed the desktop
build.rsscript because it is not that useful at the moment and @0HyperCube had problems loading the project with rust-analyzer with it in place.