Fix Alt-based quick measurement to show document space coordinates instead of viewport space#2995
Merged
Keavon merged 5 commits intoGraphiteEditor:masterfrom Aug 18, 2025
Merged
Conversation
…stead of viewport space
Member
|
!build |
|
Keavon
approved these changes
Aug 18, 2025
Member
Keavon
left a comment
There was a problem hiding this comment.
💯
Thank you for the valuable contribution. And sorry for the delay! It normally doesn't take me this long to get to problem-free PRs but I was busier than usual.
Member
|
Please also leave a comment in the associated issue so, as a conversation participant, GitHub allows me to assign it to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2941
This PR addresses the bug where the quick measurement feature (triggered by holding Alt while hovering over a shape) displayed distances in viewport coordinates instead of document coordinates. This caused the measured distance to vary incorrectly based on zoom level.
Changes made
selected_bounds,hovered_bounds) in document space usingbounding_box_document.document_to_viewporttransform only once during rendering, preserving measurement accuracy.Before
After
Visual verification
Screencast.from.08-04-2025.11.43.41.PM.webm