Skip to content

Eliminate bare Graphic and Artboard graph data by making Merge and Artboard nodes internally use tables#2996

Merged
Keavon merged 2 commits intomasterfrom
remove-bare-graphic-and-artboard
Aug 5, 2025
Merged

Eliminate bare Graphic and Artboard graph data by making Merge and Artboard nodes internally use tables#2996
Keavon merged 2 commits intomasterfrom
remove-bare-graphic-and-artboard

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Aug 5, 2025

  • Remove the "To Element" node and replaces it with the "Wrap Graphic" node which produces table instead of singleton data
  • Rename the "To Group" node to "To Graphic"
  • Rename the "Flatten Group" node to "Flatten Graphic"
  • Rename the "Layer" internal node to "Extend" and make it public-facing, while also removing its source_node_id setting functionality and making it work by concatenating two tables instead of pushing an element to a table
  • Update the "Merge" node internals to avoid using singleton Graphic type data and use Table<Graphic> instead, like everywhere else
  • Update the "Artboard" node internals to avoid using singleton Artboard type data and use Table<Artboard> instead, like everywhere else
  • Rename the internal "To Artboard" node to "Create Artboard" and make it produce Table<Artboard> instead of singleton Artboard data
  • Remove the "Append Artboard" internal node now that it can also use the new "Extend" node
  • Create the "Source Node ID" node which breaks out the source_node_id setting functionality from the internal "Layer" and "Append Artboard" nodes to make it reusable
  • Rename the "Unwrap" node to "Unwrap Option"

@Keavon Keavon force-pushed the remove-bare-graphic-and-artboard branch from 3b44b77 to fd61f5a Compare August 5, 2025 07:04
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 5, 2025 07:07 Inactive
@github-actions github-actions Bot temporarily deployed to graphite-dev (Preview) August 5, 2025 08:59 Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2025

Performance Benchmark Results

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 26,718,188 (master) -> 27,810,592 (HEAD) : $$\color{red}+4.09\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     329,324|    354,014          +7.50%
D1mw                     103,816|    119,047         +14.67%
DLmr                      32,746|     36,345         +10.99%
DLmw                      49,349|     53,974          +9.37%
Dr                     6,484,300|  6,757,789          +4.22%
Dw                     4,584,251|  4,781,067          +4.29%
EstimatedCycles       42,226,505| 44,188,460          +4.65%
I1mr                      54,699|     52,737          -3.59%
ILmr                         852|        875          +2.70%
Ir                    26,718,188| 27,810,592          +4.09%
L1hits                37,298,900| 38,823,650          +4.09%
LLhits                   404,892|    434,604          +7.34%
RamHits                   82,947|     91,194          +9.94%
TotalRW               37,786,739| 39,349,448          +4.14%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 13,657,621 (master) -> 14,925,822 (HEAD) : $$\color{red}+9.29\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     161,617|    183,107         +13.30%
D1mw                      51,273|     62,390         +21.68%
DLmr                         798|      1,282         +60.65%
DLmw                      16,040|     18,366         +14.50%
Dr                     3,317,115|  3,597,669          +8.46%
Dw                     2,333,761|  2,544,626          +9.04%
EstimatedCycles       20,790,801| 22,764,047          +9.49%
I1mr                      26,001|     25,718          -1.09%
ILmr                         720|        721          +0.14%
Ir                    13,657,621| 14,925,822          +9.29%
L1hits                19,069,606| 20,796,902          +9.06%
LLhits                   221,333|    250,846         +13.33%
RamHits                   17,558|     20,369         +16.01%
TotalRW               19,308,497| 21,068,117          +9.11%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 2,263,178 (master) -> 3,138,969 (HEAD) : $$\color{red}+38.70\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      23,461|     37,521         +59.93%
D1mw                      10,833|     11,775          +8.70%
DLmr                          21|         22          +4.76%
DLmw                       1,601|      2,706         +69.02%
Dr                       523,515|    753,236         +43.88%
Dw                       382,292|    532,153         +39.20%
EstimatedCycles        3,398,225|  4,746,496         +39.68%
I1mr                       5,556|      5,476          -1.44%
ILmr                         706|        707          +0.14%
Ir                     2,263,178|  3,138,969         +38.70%
L1hits                 3,129,135|  4,369,586         +39.64%
LLhits                    37,522|     51,337         +36.82%
RamHits                    2,328|      3,435         +47.55%
TotalRW                3,168,985|  4,424,358         +39.61%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 14,191,739 (master) -> 15,017,798 (HEAD) : $$\color{red}+5.82\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     172,825|    195,678         +13.22%
D1mw                      66,499|     68,149          +2.48%
DLmr                         165|        106         -35.76%
DLmw                      18,905|     16,225         -14.18%
Dr                     3,443,737|  3,620,202          +5.12%
Dw                     2,456,673|  2,584,377          +5.20%
EstimatedCycles       21,729,863| 22,874,657          +5.27%
I1mr                      20,817|     20,468          -1.68%
ILmr                         835|        839          +0.48%
Ir                    14,191,739| 15,017,798          +5.82%
L1hits                19,832,008| 20,938,082          +5.58%
LLhits                   240,236|    267,125         +11.19%
RamHits                   19,905|     17,170         -13.74%
TotalRW               20,092,149| 21,222,377          +5.63%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 32,223,933 (master) -> 33,852,721 (HEAD) : $$\color{red}+5.05\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     408,436|    433,143          +6.05%
D1mw                     134,918|    142,771          +5.82%
DLmr                      46,209|     52,201         +12.97%
DLmw                      62,848|     56,556         -10.01%
Dr                     7,758,390|  8,167,856          +5.28%
Dw                     5,498,722|  5,788,466          +5.27%
EstimatedCycles       51,193,901| 53,635,807          +4.77%
I1mr                      60,475|     58,582          -3.13%
ILmr                         861|        869          +0.93%
Ir                    32,223,933| 33,852,721          +5.05%
L1hits                44,877,216| 47,174,547          +5.12%
LLhits                   493,911|    524,870          +6.27%
RamHits                  109,918|    109,626          -0.27%
TotalRW               45,481,045| 47,809,043          +5.12%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 20,277,392 (master) -> 21,445,466 (HEAD) : $$\color{red}+5.76\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     247,840|    266,767          +7.64%
D1mw                      80,855|     84,310          +4.27%
DLmr                      14,673|     18,992         +29.44%
DLmw                      28,276|     43,232         +52.89%
Dr                     4,905,252|  5,201,353          +6.04%
Dw                     3,469,941|  3,676,489          +5.95%
EstimatedCycles       31,444,301| 33,778,170          +7.42%
I1mr                      41,109|     39,876          -3.00%
ILmr                         801|        811          +1.25%
Ir                    20,277,392| 21,445,466          +5.76%
L1hits                28,282,781| 29,932,355          +5.83%
LLhits                   326,054|    327,918          +0.57%
RamHits                   43,750|     63,035         +44.08%
TotalRW               28,652,585| 30,323,308          +5.83%

@Keavon Keavon merged commit 2e13964 into master Aug 5, 2025
4 checks passed
@Keavon Keavon deleted the remove-bare-graphic-and-artboard branch August 5, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants